-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/feature criar layout module #55 #63
Conversation
Deploy preview for portal-ascepa ready! ✅ Preview Built with commit 52a7a55. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
… para readme local
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Com base na revisão e nos testes realizados, aprovo a integração deste módulo ao branch principal.
Parabéns pelo excelente trabalho!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mandei uma duvida para possível padronização para documentação
modules/layout/README.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seria bom verificar para não deixar talvez redundante esta parte da documentação:
layout
ou
Module Layout
Joguei a duvida no Discord
m[Merge PR to create module layout in project to create modules like header and footer |
Descrição
--- Criado modulo de layout onde serão implementados componentes do portal, tais como header, footer entre outros.
para criação do mesmo foi utlizado o NX com comando [npx nx generate @portal-ascepa/angular-plugin:module --name=layout]
Tipo da alteração
feat: Uma nova funcionalidade
--- FEAT criando modulo layout
Checklist
Outras observações
--- adiciona commentário ao README do modulo cirado