feat: Add semver_range to dependency processing and improve logging #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhheider
reviewed
Dec 13, 2024
|
Fixed |
|
Sorry about the late review. Some comments:
|
sanchitram1
requested changes
Jan 2, 2025
| dependency_id = self.package_cache.get(item["crate_id"]) | ||
| version_id = self.version_cache.get(item["version_id"]) | ||
|
|
||
| if not dependency_id: |
| version_id=version_id, | ||
| dependency_id=dependency_id, | ||
| semver_range=item.get("semver_range"), # Add semver_range | ||
| ).to_dict() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for populating the
semver_rangefield in theDependsOntable.Improves logging for missing licenses and packages.
Changes
Modified
_process_depends_onincore/db.pyto includesemver_range.Improved logging in
core/db.pyfor better debugging.Why This Change is Necessary
Ensures the
semver_rangefield is populated, making dependency data more granular and useful.Provides clearer debugging messages for missing licenses and dependencies.
Additional Changes
Replaced all instances of
self.logger.warnwithself.logger.logas per feedback from the maintainers.