Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sync watcher exclusions with tsconfig.json #1624

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

xakdog
Copy link
Contributor

@xakdog xakdog commented Oct 7, 2024

Goal

Simplify configuration for mono repos with Keel and front-end projects

Problem

  1. Keel requires schema.keel at the project root in mono repos
  2. To prevent Keel from treating front-end JS as functions, we exclude directories in tsconfig.json
  3. However, the watcher still triggers on these excluded directories

Solution

Make the watcher respect exclude paths from tsconfig.json

Note

This change only affects watcher behavior, not compilation or deployment processes

@xakdog xakdog force-pushed the watcher-tsconfig-exclude branch from f773fdf to 81f20e5 Compare October 7, 2024 12:12
Copy link
Contributor

@RutZap RutZap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xakdog Thank you so much for contributing! We really like the approach and picking up the exclude paths from tsconfig is great.

I've had a quick play with this and it seems that there are some issues with the pattern matching; keel allows us to pass a base path to the project as a cli arg; e.g. keel run -d ./../../path/to/project. When using it like so, it seems that the watcher fails to ignore the .build folder which then it causes it to get stuck in a continuous rebuild loop. I'm not 100% sure what the fix is at the moment; as soon as we fix this issue we'll look at merging this through.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants