Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: smarter transactions and authorization for built-in actions #1347

Merged
merged 6 commits into from
Jan 5, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: functions didnt require permissions at all
davenewza committed Jan 5, 2024
commit 377d168d0391aed491fd40fde20fe49069553320
36 changes: 27 additions & 9 deletions integration/testdata/functions_custom/schema.keel
Original file line number Diff line number Diff line change
@@ -38,15 +38,33 @@ model Person {
}

actions {
read countName(name) returns (CountResponse)
read countNameAdvanced(AdvancedSearchInput) returns (CountResponse)
write createAndCount(name) returns (CountResponse)
write createManyAndCount(CreateManyInput) returns (CountResponse)
read people(PeopleInput) returns (PeopleResponse)
read customPersonSearch(CustomPersonSearchInput) returns (CustomPersonSearchResponse)
read customSearch(Any) returns (Any)
write bulkPersonUpload(BulkPersonUpload) returns (BulkPersonUpload)
read noInputs() returns (Any)
read countName(name) returns (CountResponse) {
@permission(expression: true)
}
read countNameAdvanced(AdvancedSearchInput) returns (CountResponse) {
@permission(expression: true)
}
write createAndCount(name) returns (CountResponse) {
@permission(expression: true)
}
write createManyAndCount(CreateManyInput) returns (CountResponse) {
@permission(expression: true)
}
read people(PeopleInput) returns (PeopleResponse) {
@permission(expression: true)
}
read customPersonSearch(CustomPersonSearchInput) returns (CustomPersonSearchResponse) {
@permission(expression: true)
}
read customSearch(Any) returns (Any) {
@permission(expression: true)
}
write bulkPersonUpload(BulkPersonUpload) returns (BulkPersonUpload) {
@permission(expression: true)
}
read noInputs() returns (Any) {
@permission(expression: true)
}
}

@permission(
12 changes: 9 additions & 3 deletions integration/testdata/functions_http/schema.keel
Original file line number Diff line number Diff line change
@@ -1,7 +1,13 @@
model TestModel {
actions {
read withQueryParams(Any) returns (Any)
read withHeaders(Any) returns (Any)
read withStatus(Any) returns (Any)
read withQueryParams(Any) returns (Any) {
@permission(expression: true)
}
read withHeaders(Any) returns (Any) {
@permission(expression: true)
}
read withStatus(Any) returns (Any) {
@permission(expression: true)
}
}
}