Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve @permission attribute validation #1295

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Conversation

jonbretman
Copy link
Member

@jonbretman jonbretman commented Nov 13, 2023

Better error when trying to use a role but no roles defined in your schema yet. Current error is just "Invalid value".
Screenshot 2023-11-13 at 10 00 22

Validation error for providing actions inside an action or a job
Screenshot 2023-11-13 at 10 00 57
Screenshot 2023-11-13 at 10 02 50

Validation error for using row-based permission in a read/write function
Screenshot 2023-11-13 at 11 06 57

@jonbretman jonbretman requested a review from a team November 13, 2023 10:06
@jonbretman jonbretman force-pushed the permission-validation branch from b0abcf6 to 629a4b3 Compare November 13, 2023 10:50
@jonbretman jonbretman force-pushed the permission-validation branch from 629a4b3 to 9afc2e1 Compare November 13, 2023 11:06
Copy link
Contributor

@davenewza davenewza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jonbretman jonbretman merged commit 0735a11 into main Nov 14, 2023
10 checks passed
@jonbretman jonbretman deleted the permission-validation branch November 14, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants