fix: @set expression schema validations

[davenewza]

@set attribute expression validations

The @set attribute has been almost entirely void of schema validations. In this PR we provide a bunch of support for validating these expressions.

Furthermore, improved some of the validation messaging.

Setting related data outside the scope of the input:

model User {
    fields {
        name Text
        company Company
    }
    actions {
        // This is valid
        create createUser() with (name, company.name, company.address) {
            @set(user.company.isActive = true)
        }

        // This is invalid
        create createUser() with (name, company.id) {
            @set(user.company.isActive = true)
        }

        // This is also invalid - a more complex example
        create createUser() with (
                  name, 
                  company.name, 
                  company.address, 
                  company.employees.name,
                  company.employees.country.id
                  company.employees.title)
            @set(user.company.isActive = true) // valid
            @set(user.company.employees.isActive = true) // valid
            @set(user.company.employees.country.capital = "Something") // Not valid!
        }
    }
}

Example of validation message

Validate against setting ctx, inputs, using multiple conditions and other nonsense:

model User {
    fields {
        name Text
    }

    actions {
        create createUser() {
            @set(ctx.identity = user.identity) // not valid!
        }

        create createUser() {
            @set(name = ctx.identity.email) // not valid!
        }

        create createUser() {
            @set("hello" = user.name) // not valid!
        }

        create createUser() {
            @set(post.published = true and post.name = "hello") // not valid!
        }

       create createUser() {
            @set(post.published) // not valid!
        }
    }
}

Examples of validation message

LInear tickets completed:

• https://linear.app/keel/issue/KE-1203/memory-leak-and-invalid-schema
• https://linear.app/keel/issue/KE-1194/set-schema-validation-for-setting-ctx-inputs-relationships-null

[louisaspicer]

Basic question but, for the example:

  @set(user.company.employees.isActive = true) // valid
  @set(user.company.employees.country.capital = "Something") // Not valid!

What makes the first one valid verses the second one? is it because country is two levels deep?

[davenewza]

 create createUser() with (
                  name, 
                  company.name, 
                  company.address, 
                  company.employees.name,
                  company.employees.country.id
                  company.employees.title)
            @set(user.company.isActive = true) // valid
            @set(user.company.employees.isActive = true) // valid
            @set(user.company.employees.country.capital = "Something") // Not valid!
        }

@louisaspicer if you look at the inputs of the action, you can see that we are associating country (and not creating it). So it should not be possible to set a field on an already existing record which one is referencing - I hope that makes sense

[louisaspicer]

@louisaspicer if you look at the inputs of the action, you can see that we are associating country (and not creating it). So it should not be possible to set a field on an already existing record which one is referencing - I hope that makes sense

Ohh got it 👍 makes sense, thanks