Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: init to support non-empty directories #1249

Merged
merged 1 commit into from
Oct 24, 2023
Merged

fix: init to support non-empty directories #1249

merged 1 commit into from
Oct 24, 2023

Conversation

tomfrew
Copy link
Contributor

@tomfrew tomfrew commented Oct 21, 2023

Previous behaviour

  • When running keel init in a non-empty directory it would just error and exit
  • This included an "empty" directory that had just been git initialised (i.e. contained a .git directory)

New behaviour

  • keel init will run in non-empty directories but will not overwrite any existing files
  • The command output shows which files have been generated and while have been skipped due to existing files

Note

This is a quick fix to improve the DX of this command. An overhaul of the keel init command is coming soon

@tomfrew tomfrew requested a review from a team October 21, 2023 13:02
Copy link
Contributor

@davenewza davenewza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need this feature like every single time I start a new Keel app 👏

@tomfrew tomfrew merged commit eec6a0b into main Oct 24, 2023
9 checks passed
@tomfrew tomfrew deleted the init-fix branch October 24, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants