-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(webauthn): change user_id from uuid.UUID to string #9
Conversation
WIP: Need to rework how to get a list of credentials now |
81ae080
to
013eade
Compare
* remove host description * remove path prefix description Related to: #5
Would be good if the change from uuid to string is backwards compatible. |
Hmm, is that should already be possible except for migrating down. Do you have an example where this is not possible? |
Yes, when you created a credential with a uuid without the changes from this PR (e.g. v0.1.0) and then you want to login with the credential with the changes from this PR, then you get an error: |
* handle credentials which were created with v1 by trying to convert the userHandle into an uuid and then converting the uuid into a string Related to: #5
Fixed the backward compatibility issue by trying to convert the userHandle into an uuid. I also needed to overwrite the parsedRequest.Response.UserHandle because it is used to check if user ID and handle match in the webauthn lib |
allows any string as user id
Related to: #5