Skip to content

Commit

Permalink
fix: create new flow for every request
Browse files Browse the repository at this point in the history 
Create a new flow for every request, because the flowBuilder is not save for concurrent usage.
  • Loading branch information
@FreddyDevelop
FreddyDevelop committed Aug 26, 2024
1 parent 99dc71e commit 9ff8453
Show file tree
Hide file tree
Showing 2 changed files with 92 additions and 78 deletions.
162 changes: 87 additions & 75 deletions backend/flow_api/flow/flows.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -76,80 +76,92 @@ var UserDetailsSubFlow = flowpilot.NewSubFlow(shared.FlowUserDetails).
user_details.SkipEmail{}).
MustBuild()

var LoginFlow = flowpilot.NewFlow(shared.FlowLogin).
State(shared.StateSuccess).
InitialState(shared.StatePreflight, shared.StateLoginInit).
ErrorState(shared.StateError).
BeforeState(shared.StateLoginInit,
login.WebauthnGenerateRequestOptionsForConditionalUi{}).
BeforeState(shared.StateSuccess,
shared.IssueSession{},
shared.GetUserData{}).
AfterState(shared.StateOnboardingVerifyPasskeyAttestation,
shared.WebauthnCredentialSave{}).
AfterState(shared.StatePasscodeConfirmation,
shared.EmailPersistVerifiedStatus{}).
AfterState(shared.StatePasswordCreation,
shared.PasswordSave{}).
AfterState(shared.StateOnboardingEmail, login.CreateEmail{}).
AfterState(shared.StatePasscodeConfirmation, login.CreateEmail{}).
AfterFlow(shared.FlowCredentialUsage, login.ScheduleOnboardingStates{}).
SubFlows(
CapabilitiesSubFlow,
CredentialUsageSubFlow,
CredentialOnboardingSubFlow,
UserDetailsSubFlow).
TTL(24 * time.Hour)
func NewLoginFlow(debug bool) flowpilot.Flow {
return flowpilot.NewFlow(shared.FlowLogin).
State(shared.StateSuccess).
InitialState(shared.StatePreflight, shared.StateLoginInit).
ErrorState(shared.StateError).
BeforeState(shared.StateLoginInit,
login.WebauthnGenerateRequestOptionsForConditionalUi{}).
BeforeState(shared.StateSuccess,
shared.IssueSession{},
shared.GetUserData{}).
AfterState(shared.StateOnboardingVerifyPasskeyAttestation,
shared.WebauthnCredentialSave{}).
AfterState(shared.StatePasscodeConfirmation,
shared.EmailPersistVerifiedStatus{}).
AfterState(shared.StatePasswordCreation,
shared.PasswordSave{}).
AfterState(shared.StateOnboardingEmail, login.CreateEmail{}).
AfterState(shared.StatePasscodeConfirmation, login.CreateEmail{}).
AfterFlow(shared.FlowCredentialUsage, login.ScheduleOnboardingStates{}).
SubFlows(
CapabilitiesSubFlow,
CredentialUsageSubFlow,
CredentialOnboardingSubFlow,
UserDetailsSubFlow).
TTL(24 * time.Hour).
Debug(debug).
MustBuild()
}

var RegistrationFlow = flowpilot.NewFlow(shared.FlowRegistration).
State(shared.StateRegistrationInit,
registration.RegisterLoginIdentifier{},
shared.ThirdPartyOAuth{}).
State(shared.StateThirdParty,
shared.ExchangeToken{}).
State(shared.StateSuccess).
InitialState(shared.StatePreflight,
shared.StateRegistrationInit).
ErrorState(shared.StateError).
BeforeState(shared.StateSuccess,
shared.GetUserData{},
registration.CreateUser{},
shared.IssueSession{}).
SubFlows(
CapabilitiesSubFlow,
CredentialUsageSubFlow,
CredentialOnboardingSubFlow,
UserDetailsSubFlow).
TTL(24 * time.Hour)
func NewRegistrationFlow(debug bool) flowpilot.Flow {
return flowpilot.NewFlow(shared.FlowRegistration).
State(shared.StateRegistrationInit,
registration.RegisterLoginIdentifier{},
shared.ThirdPartyOAuth{}).
State(shared.StateThirdParty,
shared.ExchangeToken{}).
State(shared.StateSuccess).
InitialState(shared.StatePreflight,
shared.StateRegistrationInit).
ErrorState(shared.StateError).
BeforeState(shared.StateSuccess,
shared.GetUserData{},
registration.CreateUser{},
shared.IssueSession{}).
SubFlows(
CapabilitiesSubFlow,
CredentialUsageSubFlow,
CredentialOnboardingSubFlow,
UserDetailsSubFlow).
TTL(24 * time.Hour).
Debug(debug).
MustBuild()
}

var ProfileFlow = flowpilot.NewFlow(shared.FlowProfile).
State(shared.StateProfileInit,
profile.AccountDelete{},
profile.EmailCreate{},
profile.EmailDelete{},
profile.EmailSetPrimary{},
profile.EmailVerify{},
profile.PasswordCreate{},
profile.PasswordUpdate{},
profile.PasswordDelete{},
profile.UsernameCreate{},
profile.UsernameUpdate{},
profile.UsernameDelete{},
profile.WebauthnCredentialRename{},
profile.WebauthnCredentialCreate{},
profile.WebauthnCredentialDelete{},
).
State(shared.StateProfileWebauthnCredentialVerification,
profile.WebauthnVerifyAttestationResponse{},
shared.Back{}).
State(shared.StateProfileAccountDeleted).
InitialState(shared.StatePreflight, shared.StateProfileInit).
ErrorState(shared.StateError).
BeforeEachAction(profile.RefreshSessionUser{}).
BeforeState(shared.StateProfileInit, profile.GetProfileData{}).
AfterState(shared.StateProfileWebauthnCredentialVerification, shared.WebauthnCredentialSave{}).
AfterState(shared.StatePasscodeConfirmation, shared.EmailPersistVerifiedStatus{}).
SubFlows(
CapabilitiesSubFlow,
CredentialUsageSubFlow).
TTL(24 * time.Hour)
func NewProfileFlow(debug bool) flowpilot.Flow {
return flowpilot.NewFlow(shared.FlowProfile).
State(shared.StateProfileInit,
profile.AccountDelete{},
profile.EmailCreate{},
profile.EmailDelete{},
profile.EmailSetPrimary{},
profile.EmailVerify{},
profile.PasswordCreate{},
profile.PasswordUpdate{},
profile.PasswordDelete{},
profile.UsernameCreate{},
profile.UsernameUpdate{},
profile.UsernameDelete{},
profile.WebauthnCredentialRename{},
profile.WebauthnCredentialCreate{},
profile.WebauthnCredentialDelete{},
).
State(shared.StateProfileWebauthnCredentialVerification,
profile.WebauthnVerifyAttestationResponse{},
shared.Back{}).
State(shared.StateProfileAccountDeleted).
InitialState(shared.StatePreflight, shared.StateProfileInit).
ErrorState(shared.StateError).
BeforeEachAction(profile.RefreshSessionUser{}).
BeforeState(shared.StateProfileInit, profile.GetProfileData{}).
AfterState(shared.StateProfileWebauthnCredentialVerification, shared.WebauthnCredentialSave{}).
AfterState(shared.StatePasscodeConfirmation, shared.EmailPersistVerifiedStatus{}).
SubFlows(
CapabilitiesSubFlow,
CredentialUsageSubFlow).
TTL(24 * time.Hour).
Debug(debug).
MustBuild()
}
8 changes: 5 additions & 3 deletions backend/flow_api/handler.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -39,15 +39,17 @@ type FlowPilotHandler struct {
}

func (h *FlowPilotHandler) RegistrationFlowHandler(c echo.Context) error {
return h.executeFlow(c, flow.RegistrationFlow.Debug(h.Cfg.Debug).MustBuild())
registrationFlow := flow.NewRegistrationFlow(h.Cfg.Debug)
return h.executeFlow(c, registrationFlow)
}

func (h *FlowPilotHandler) LoginFlowHandler(c echo.Context) error {
return h.executeFlow(c, flow.LoginFlow.Debug(h.Cfg.Debug).MustBuild())
loginFlow := flow.NewLoginFlow(h.Cfg.Debug)
return h.executeFlow(c, loginFlow)
}

func (h *FlowPilotHandler) ProfileFlowHandler(c echo.Context) error {
profileFlow := flow.ProfileFlow.Debug(h.Cfg.Debug).MustBuild()
profileFlow := flow.NewProfileFlow(h.Cfg.Debug)

if err := h.validateSession(c); err != nil {
flowResult := profileFlow.ResultFromError(err)
Expand Down

0 comments on commit 9ff8453

Please sign in to comment.