Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(format): 使用 prettierjs 格式化项目 #429

Open
wants to merge 1 commit into
base: release
Choose a base branch
from
Open

chore(format): 使用 prettierjs 格式化项目 #429

wants to merge 1 commit into from

Conversation

chuan6
Copy link
Contributor

@chuan6 chuan6 commented Mar 11, 2018 •
edited
Loading

Note:

  • 必须能保证不干扰 rxjs-marble 测试代码中的空格

@chuan6
Copy link
Contributor Author

chuan6 commented Mar 11, 2018 •
edited
Loading

@aicest 谢谢你的 PR #428 ，我把其中使用 prettierjs 格式化工具的内容迁移到这个 PR 来了，目标是通过这个 PR 一次性将所有 SDK 代码在合适的时机（不与其他 PR 产生冲突，具体应该是等 #329 合掉）用 prettierjs 格式化掉。让这个 PR 简单地只剩下格式化和 prettierjs 配置，理论上避免影响程序正确性的可能，避免未来 git blame 到这个 PR 而浪费时间在大量的 diff 里寻找可能的 bug。

@aicest @chuan6
chore: 添加“commitizen => husky => lint-staged => prettier”工具链
8e473b4 
TODO: 目前 madge 只能检测 JS 循环依赖，因此需要先执行 `npm run build_cjs` 再执行 `npm run
check_circular_dependencies`，期待以后能够直接对 TS 文件做检测
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.9%) to 94.874% when pulling 8e473b4 on chore/prettier into b4a70a1 on release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chuan6 @coveralls @aicest