Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update coppercore to 2025 #62

Merged
merged 3 commits into from
Dec 6, 2024
Merged

Update coppercore to 2025 #62

merged 3 commits into from
Dec 6, 2024

Conversation

aidnem
Copy link
Contributor

@aidnem aidnem commented Dec 5, 2024

Changes:

  • Change all build.gradles that reference advantagekit or wpilib versions to use variables.
  • Update wpilib to 2025.1.1-beta-1
  • Update advantagekit to 4.0.0-alpha-1
  • Change coppercore vision to 2025.0.0-beta

@aidnem aidnem linked an issue Dec 5, 2024 that may be closed by this pull request
@aidnem
Copy link
Contributor Author

aidnem commented Dec 5, 2024

@jkleiber What would you prefer that I version this code as? The ideas I have in mind are 2025.0.0-beta, or 2024.12.5-beta, although I find the 2024 to be slightly misleading since it's now using 2025 code.

@jkleiber
Copy link
Member

jkleiber commented Dec 5, 2024

I prefer 2025.0.0-beta since it is clearly 2025 and a prerelease

@jkleiber
Copy link
Member

jkleiber commented Dec 6, 2024

@aidnem after you merge this, create a release on github to automatically add the new version to maven central

We can always release to the same version twice if we want (this is not great practice but we're still early enough into development that it's fine imo)

@aidnem aidnem merged commit ae92bd0 into main Dec 6, 2024
6 checks passed
@aidnem aidnem deleted the 2025core branch December 6, 2024 17:10
@aidnem
Copy link
Contributor Author

aidnem commented Dec 6, 2024

@jkleiber would you mind taking a look at the draft release to make sure everything is okay? I've never made a release before.

@jkleiber
Copy link
Member

jkleiber commented Dec 6, 2024

@aidnem LGTM

@aidnem
Copy link
Contributor Author

aidnem commented Dec 7, 2024

Thanks, release published now.

@aidnem
Copy link
Contributor Author

aidnem commented Dec 7, 2024

@jkleiber should the action automatically run to publish or do I have to run it myself?

@jkleiber
Copy link
Member

jkleiber commented Dec 7, 2024

@aidnem it should run automatically but it looks like it didn't. I might have broken the workflow when I was fixing maven publishing in general. For this one try running it manually

@aidnem
Copy link
Contributor Author

aidnem commented Dec 7, 2024

Okay, I ran it and it looks like it's published now. I'll try importing and using it tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade coppercore to 2025
2 participants