generated from wpilibsuite/vendor-template
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add json naming #48
Closed
Closed
Add json naming #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
2 tasks
* WIP - try to port monitors but the packages can't see each other yet so it's all broken * Fix MonitoredSubsystem but its still broken * Try to add AdvantageKit, now none of my imports work instead of only some of them * Turns out excluding wpilibj made us unable to import wpilibj, now just need to fix other import issues * Add builder pattern and fix tests for Monitor * Fix WPI imports and MAYBE fix advantagekit, must test out of codespace to confirm * GREAT SCOTT GLORY HALLELUJAH IT BUILDS * Remove to-do comment that had already been done * Simplify boolean logic in Monitor and improve code comments * Update normal comments to be doc comments for fields of Monitor * Remove gradleRIO and manually add wpilib dependencies instead * Add ability to enable and disable logging for MonitoredSubsystem and for each individual Monitor * Make MonitoredSubsystem an abstract class to force users to override monitoredPeriodic * Add tests for monitor fault callbacks * Fix wpilib_interface's build.gradle so that imports work again --------- Co-authored-by: aidnem <>
* Enables loading coppercore in maven local * Switching to the io.github.coppercore namespace * Adds a new github action for publishing to maven central * Fixes javadoc errors caused by not being able to find wpilib references in comments
* Actually gets deploying to central portal to work locally * Updates workflows to allow testing of publishing * Updates documentation and ready to test the library auto-publish * Makes signing only happen in github actions in order to allow for local publishing to not need GPG keys * Updates documentation for external users * Changes apostrophes to double quotes
…into addJsonNaming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Must be merged after AddJSONSaving