Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Saving of JSON #46

Merged
merged 13 commits into from
Dec 3, 2024
Merged

Add Saving of JSON #46

merged 13 commits into from
Dec 3, 2024

Conversation

avidraccoon
Copy link
Contributor

No description provided.

@avidraccoon avidraccoon linked an issue Nov 23, 2024 that may be closed by this pull request
3 tasks
@avidraccoon avidraccoon marked this pull request as draft November 23, 2024 23:45
@avidraccoon avidraccoon self-assigned this Nov 23, 2024
@avidraccoon avidraccoon marked this pull request as ready for review November 24, 2024 00:09
Copy link
Contributor

@linglejack06 linglejack06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this all loooks good, just had one comment on the saving with json exclude. Also, what exactly do we need this saving feature for? it seems as though we should be changing our json in json not in code (as that wwould be overwriting every time we set it and ask to save it)

@jkleiber
Copy link
Member

@linglejack06 if we are able to save JSON based on log tunable number, then all we would need to do is figure out a way to sync the constants back from the robot to the driverstation

I'm thinking of the following process:

  1. We are in test mode tuning stuff
  2. We find a configuration for certain constants we want to save
  3. We save the constants to JSON (no redeploy needed when restarting the robot)
  4. Somehow we get the constants sent back to the driverstation repo (TBD how this works, maybe just FTP)
  5. We check in the changes to the JSON files and push them to the repo

@jkleiber
Copy link
Member

jkleiber commented Dec 2, 2024

@avidraccoon this looks good, please fix the merge conflicts so we can do a final pass review

Copy link
Contributor

@linglejack06 linglejack06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just left the one comment about the setting file, once thats answered i can approve

Copy link
Contributor

@linglejack06 linglejack06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm @jkleiber what do you think?

@linglejack06 linglejack06 self-requested a review December 3, 2024 00:14
@avidraccoon avidraccoon requested a review from aidnem December 3, 2024 00:27
@avidraccoon avidraccoon marked this pull request as draft December 3, 2024 00:30
@avidraccoon avidraccoon marked this pull request as ready for review December 3, 2024 00:30
@avidraccoon avidraccoon closed this Dec 3, 2024
@avidraccoon avidraccoon reopened this Dec 3, 2024
@avidraccoon
Copy link
Contributor Author

@jkleiber We cant figure out why this can't be merged

@jkleiber
Copy link
Member

jkleiber commented Dec 3, 2024

@avidraccoon try now, just needed to be approved

@PChild PChild merged commit 994c331 into main Dec 3, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add saving json
5 participants