-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Saving of JSON #46
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this all loooks good, just had one comment on the saving with json exclude. Also, what exactly do we need this saving feature for? it seems as though we should be changing our json in json not in code (as that wwould be overwriting every time we set it and ask to save it)
@linglejack06 if we are able to save JSON based on log tunable number, then all we would need to do is figure out a way to sync the constants back from the robot to the driverstation I'm thinking of the following process:
|
@avidraccoon this looks good, please fix the merge conflicts so we can do a final pass review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just left the one comment about the setting file, once thats answered i can approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm @jkleiber what do you think?
@jkleiber We cant figure out why this can't be merged |
@avidraccoon try now, just needed to be approved |
No description provided.