Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic Gradle Library Implementation #3

Merged
merged 7 commits into from
Apr 30, 2024
Merged

Conversation

linglejack06
Copy link
Contributor

Summary: Create a basic gradle library to hold common code across years starting with utils folder

Changes:

  • add WPILIb implementation dependencies
  • add WPILib plugins
  • copy utils folder from 2024-robot-code

@linglejack06 linglejack06 self-assigned this Apr 16, 2024
@linglejack06
Copy link
Contributor Author

@jkleiber I've got most things migrated over, however, I am having some difficulty with the build.gradle.kts file, do you have experience creating/modifying the file?

@jkleiber
Copy link
Member

@linglejack06 I've modified build.gradle a lot before, but I'm not sure what build.gradle.kts is. I'll look into it some, but lmk if you figure it out

@jkleiber
Copy link
Member

@linglejack06
Copy link
Contributor Author

@jkleiber ill check the link out. The .kts is just kotlin script version so it has slightly different syntax ( I can figure that part out ) I just needed some help on the implementation vs dependency etc

@jkleiber
Copy link
Member

@linglejack06 I think we should just keep the problematic wpilib deps out for now and figure it out later

@linglejack06
Copy link
Contributor Author

@jkleiber okay I can do that, I just wont be able to test anything because several util classes utilize the pose 2d class or units class. Ill remove them, and I will see if I can get them working. I assume its just an error on how I am loading them in.

@jkleiber
Copy link
Member

@linglejack06 anything using Pose we can decompose as needed into coordinates/rotation. For units, we could depend on yet another units library or add some of our own conversion constants

@linglejack06
Copy link
Contributor Author

@jkleiber everything has a basic implementation now, build.gradle kinks were worked out and command library was added for WaitForButton and feedforward tune commands. This should be ready to be merged into main

@linglejack06 linglejack06 requested a review from jkleiber April 30, 2024 20:04
Copy link
Member

@jkleiber jkleiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple comments before we merge

@linglejack06
Copy link
Contributor Author

@jkleiber command is removed as I did not find any mentions of it in robot container

Copy link
Member

@jkleiber jkleiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved!

@linglejack06 linglejack06 merged commit d21736b into main Apr 30, 2024
9 of 11 checks passed
@linglejack06 linglejack06 deleted the basic-implementation branch April 30, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants