-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic Gradle Library Implementation #3
Conversation
@jkleiber I've got most things migrated over, however, I am having some difficulty with the build.gradle.kts file, do you have experience creating/modifying the file? |
@linglejack06 I've modified build.gradle a lot before, but I'm not sure what build.gradle.kts is. I'll look into it some, but lmk if you figure it out |
@jkleiber ill check the link out. The .kts is just kotlin script version so it has slightly different syntax ( I can figure that part out ) I just needed some help on the implementation vs dependency etc |
@linglejack06 I think we should just keep the problematic wpilib deps out for now and figure it out later |
@jkleiber okay I can do that, I just wont be able to test anything because several util classes utilize the pose 2d class or units class. Ill remove them, and I will see if I can get them working. I assume its just an error on how I am loading them in. |
@linglejack06 anything using Pose we can decompose as needed into coordinates/rotation. For units, we could depend on yet another units library or add some of our own conversion constants |
@jkleiber everything has a basic implementation now, build.gradle kinks were worked out and command library was added for WaitForButton and feedforward tune commands. This should be ready to be merged into main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple comments before we merge
lib/src/main/java/coppercore/commands/WaitForButtonCommand.java
Outdated
Show resolved
Hide resolved
@jkleiber command is removed as I did not find any mentions of it in robot container |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved!
Summary: Create a basic gradle library to hold common code across years starting with utils folder
Changes: