Aim motor adjustments in case of failure #154
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h velocity as well as stator current when i was using current to see if the motor was dead but convienently wpilib has an "isalive" function that hopefully works
… should i add anything else?
jkleiber
reviewed
Mar 9, 2024
Comment on lines
144
to
158
| if ((!aimerLeft.isAlive()) | ||
| || // if motor disconnected | ||
| (Math.abs(aimerRight.getStatorCurrent().getValueAsDouble()) | ||
| - Math.abs(aimerLeft.getStatorCurrent().getValueAsDouble()) | ||
| > 1 | ||
| && Math.abs(aimerLeft.getMotorVoltage().getValueAsDouble()) > 0.5) | ||
| || // if motor voltage is really small when it shouldn't be | ||
| (Math.abs(aimerLeft.getStatorCurrent().getValueAsDouble()) | ||
| - Math.abs(aimerRight.getStatorCurrent().getValueAsDouble()) | ||
| > 1 | ||
| && Math.abs(aimerLeft.getMotorVoltage().getValueAsDouble()) | ||
| < 0.5) // if motor voltage is really large when it shouldn't be | ||
| ) { | ||
| motorLeftFailure = true; | ||
| } |
There was a problem hiding this comment.
Since we are duplicating a lot of this code below, could we make this into a function that returns a boolean on if the motor is faulty or not?
Comment on lines
201
to
202
| if (!motorLeftFailure || motorCheckOverriden) aimerLeft.setVoltage(overrideVolts); | ||
| else aimerRight.setVoltage(overrideVolts); |
There was a problem hiding this comment.
Can we use curly braces on if/else statements?
Comment on lines
204
to
206
| if (!motorLeftFailure || motorCheckOverriden) | ||
| aimerLeft.setControl(controller.withPosition(goalAngleRad)); | ||
| else aimerRight.setControl(controller.withPosition(goalAngleRad)); |
There was a problem hiding this comment.
Can we use curly braces on if/else statements?
Comment on lines
134
to
141
| /*if (!aimerLeft.isAlive() || !aimerRight.isAlive()) { | ||
| if (!motorCheckOverriden) setFF(ScoringConstants.aimerFaultkS, ScoringConstants.aimerFaultkV, ScoringConstants.aimerFaultkA, ScoringConstants.aimerFaultkG); | ||
| motorFailure = true; | ||
| } else if (motorFailure) { | ||
| if (!motorCheckOverriden) setFF(ScoringConstants.aimerkS, ScoringConstants.aimerkV, ScoringConstants.aimerkA, ScoringConstants.aimerkG); | ||
| motorFailure = false; | ||
| } | ||
| return motorFailure;*/ |
There was a problem hiding this comment.
This looks like it can be removed
| motorRightFailure = true; | ||
| } | ||
|
|
||
| if (!motorCheckOverriden) shutOffFaultyAimMotors(); |
There was a problem hiding this comment.
Can we use curly braces on if/else statements?
| inputs.aimSupplyCurrentAmps = aimerLeft.getSupplyCurrent().getValueAsDouble(); | ||
| } | ||
|
|
||
| checkForAimMotorFailure(); |
There was a problem hiding this comment.
Should we check for motor failure at the top of this function (that way we can detect failure on the same frame we set the motor values)?
3 tasks
jkleiber
reviewed
Mar 12, 2024
Comment on lines
159
to
168
| > 1 | ||
| && Math.abs(check.getMotorVoltage().getValueAsDouble()) > 0.5) { | ||
| // motor voltage is really small when it shouldn't be | ||
| return true; | ||
| } | ||
|
|
||
| if (Math.abs(check.getStatorCurrent().getValueAsDouble()) | ||
| - Math.abs(compare.getStatorCurrent().getValueAsDouble()) | ||
| > 1 | ||
| && Math.abs(check.getMotorVoltage().getValueAsDouble()) < 0.5) { |
There was a problem hiding this comment.
Some points of feedback here:
- These thresholds should be set as constants in Constants.java
- These are really tight thresholds. 1 A or 0.5 V is common to see as a difference between two motors. Would recommend a much bigger value for amps, but this should be pulled from match/robot data where the aimer motor was not connected most likely.
- We should add a time aspect to this. "If the motors disagree by X current for 1 cycle" will yield many false positives. Let's add that they must disagree for T time
- Some of this logic looks duplicated?
jkleiber
reviewed
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added checking for both motor disconnection + disparities in current: what else should I add?