Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve aimer trapezoidal profile logic #116

Open
1 task
jkleiber opened this issue Feb 21, 2024 · 1 comment
Open
1 task

Improve aimer trapezoidal profile logic #116

jkleiber opened this issue Feb 21, 2024 · 1 comment
Labels
feature New feature or request scoring

Comments

@jkleiber
Copy link
Member

Purpose
The purpose of this addition is to address any aimer control deficiencies uncovered that are not deemed to be bad enough to fix in integration prior to VABLA.

List of such potential problems:

  • Currently we are winding up the trapezoidal profile timer by never resetting it in the PRIME state. After a period of time we should expect the control to always issue step commands. Maybe this is fine, but it does not seem like the cleanest implementation.

Project Scope

  • Clean up the implementation of the trapezoidal profile for the aimer
@jkleiber jkleiber added feature New feature or request scoring labels Feb 21, 2024
@jkleiber jkleiber added this to the Scoring Advanced milestone Feb 21, 2024
@jkleiber
Copy link
Member Author

Additional Info for the future: The behavior seen in #111 (comment) was likely caused by turning the PID controller off when near the setpoint rather than anything related to the profile improvements proposed in the scoring PR themselves.

We should still wait to get the integration branch merged before doing this change, but I wanted to leave this note that we aren't broken if we do this change in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request scoring
Projects
None yet
Development

No branches or pull requests

2 participants