Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Aimer robust to encoder wrapping #112

Open
2 tasks
aidnem opened this issue Feb 17, 2024 · 1 comment · May be fixed by #162
Open
2 tasks

Make Aimer robust to encoder wrapping #112

aidnem opened this issue Feb 17, 2024 · 1 comment · May be fixed by #162
Assignees
Labels
feature New feature or request

Comments

@aidnem
Copy link
Contributor

aidnem commented Feb 17, 2024

Purpose
Handle encoder wrap-around properly.

Project Scope

  • Figure out a way to handle the point where the encoder goes from 1 to 0 and vice-versa in an intelligent way.
  • Make the tuning process generalized across wherever the encoder is used so that encoder values are always standardized.
@aidnem aidnem added the feature New feature or request label Feb 17, 2024
@aidnem aidnem added this to the Scoring Advanced milestone Feb 17, 2024
@aidnem aidnem self-assigned this Feb 17, 2024
@jkleiber
Copy link
Member

jkleiber commented Mar 5, 2024

@redPlover let's use this ticket to implement your idea of handling negative encoder values as 0

@Bread-n-Butter06 Bread-n-Butter06 self-assigned this Mar 7, 2024
@Bread-n-Butter06 Bread-n-Butter06 linked a pull request Mar 11, 2024 that will close this issue
@aidnem aidnem removed their assignment Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants