-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
incorrect behaviour + memory leak fix #87
base: master
Are you sure you want to change the base?
Conversation
well, above check shows error not for the PR content but for setup and license acceptance. |
hey @veghtomi |
is this project live? any feedback here? |
hey @szugyi as I can see you are the last guy who committed to this repository, so I'm going to ping you here. |
Sorry for the late reply. |
Thanks for the answer here @szugyi The bad thing for me now that we have this dependency too https://github.com/ethanhua/Skeleton and this library is based on yours. Regards, |
Sorry, but I cannot release new versions. The best option is to make the change you need and use it as source, or release the fix in your own nexus repository. |
I found that if we call startAnimation more then once when the view has 0 size we will add 2 PreDrawListeners.
And everything was ok except the case when I cancel shimmer animation before the view size change. In this case - animation will start anyway because
stopShimmerAnimation
will remove only latest PreDrawListener. In this case animation will start anyway.The second thing - if I navigate back too quick I've noticed that I have a warning about memory leak from LeakCanary. And during the debug found that there can be a case when this PreDrawListener will fire without cancelling and animation will run even if the view is detached.
This PR should fix #75