chore: 구매 링크 api 수정 #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yj-leez
approved these changes
Jan 30, 2024
|
|
||
| List<PurchaseInfo> purchaseList = new ArrayList<>(); | ||
| PurchaseInfo purchaseInfo1 = PurchaseInfo.builder().link(fragrance.getLink1()).build(); | ||
| if (purchaseInfo1.getLink().startsWith("https://www.sivillage")) { |
There was a problem hiding this comment.
분기 처리하는 if-else문들은 중복되니까 메서드로 따로 빼도 좋을 것 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR
PR 요약
변경된 점
구매 링크와 이미지를 같이 보내고, 품절 여부를 확인할 수 있도록 수정
추후 엔티티를 분리하는 등의 리팩토링을 거치면 좋을 것 같다
이슈 번호