XML: keep unquoted attribute values untouched, fixes #611

tdewolff · Oct 20, 2023 · 2e816a4 · 2e816a4
1 parent 76935f3
commit 2e816a4
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/xml/xml.go b/xml/xml.go
@@ -124,7 +124,7 @@ func (o *Minifier) Minify(m *minify.M, w io.Writer, r io.Reader, _ map[string]st
 			w.Write(t.Text)
 			w.Write(isBytes)
 
-			if len(t.AttrVal) < 2 {
+			if len(t.AttrVal) < 2 || t.AttrVal[0] != '"' || t.AttrVal[len(t.AttrVal)-1] != '"' {
 				w.Write(t.AttrVal)
 			} else {
 				val := t.AttrVal[1 : len(t.AttrVal)-1]

diff --git a/xml/xml_test.go b/xml/xml_test.go
@@ -28,6 +28,7 @@ func TestXML(t *testing.T) {
 		{`<x a="b"></x>`, `<x a="b"/>`},
 		{`<x a=""></x>`, `<x a=""/>`},
 		{`<x a=a></x>`, `<x a=a/>`},
+		{`<x a=foo></x>`, `<x a=foo/>`},
 		{"<x a=\" a \n\r\t b \"/>", `<x a=" a     b "/>`},
 		{`<x a="&apos;b&quot;"></x>`, `<x a="'b&#34;"/>`},
 		{`<x a="&quot;&quot;'"></x>`, `<x a='""&#39;'/>`},