-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerify #7
base: master
Are you sure you want to change the base?
Dockerify #7
Conversation
Thanks for putting this together. Sadly I'm not a docker expert, but a couple of thoughts:
|
Sure, I can update the README and also add a new data volume to store the db. To run it with Docker (which was useful in my local testing for my other two or so PRs):
|
@tdeck Thoughts on this? I just rebased but wanted to check with you before I continue this work. |
Yep, looks good in general. I just still have the inline question about that exposed port, and also I wonder what will happen with the team database if people use this configuration. I thought that generally things in a docker container were treated as ephemeral, and you were supposed to separate out the data. But I'm not really a docker user and I assume it depends on your platform. |
Note: I set TEAM_DB_FILE=/var/run/data/teambot.db in my `.env`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this ready to be reviewed?
docker-compose.yml
Outdated
volumes: | ||
- .:/src | ||
expose: | ||
- "8000" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this needed?
@tdeck Not quite, been swapped here lately. Though I've not forgotten and will plan to make time for this ASAP. |
@tdeck I cannot seem to find your inline comment. But I think I know what you're asking about: No, we probably don't need to expose anything. I just copy pasted that from another docker-based project I'm working on and must've forgotten to remove it. Good catch! |
No hurry on my end, just want to make sure I wasn't neglecting anything. Let me know when you want me to take another look. |
TODOs: