Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Follow.recent method #75

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

amoludage
Copy link
Contributor

Issue #61

  • Added default parameter(2.weeks)

  + Added default parameter.
  + default method returns records from last 2 weeks
@jcoyne
Copy link
Collaborator

jcoyne commented Sep 6, 2016

This changes the return value for Follow.recent(nil). Can you update it so that it doesn't? Can you point out the documentation you were referring to in the issue?

@amoludage
Copy link
Contributor Author

Hi @jcoyne

Can you point out the documentation you were referring to in the issue?

See this 3 lines from documentation which are saying that you can use Follow.recent method which will return default records of last 2 weeks or you can also pass parameter to this method. But the Follow.recent method return ArgumentError: wrong number of arguments (0 for 1) error.

This changes the return value for Follow.recent(nil)

Not understood this ?? Can you please explain?

Thanks

@jcoyne
Copy link
Collaborator

jcoyne commented Sep 6, 2016

This changes the return value for Follow.recent(nil)

Prior to your change you could run Follow.recent(nil) and it would give you the followers for the last two weeks. Now it doesn't work the same. Please make it work the same to preserve backward compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants