Enable visio for DINUM instance #1079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcWadai
reviewed
Jul 23, 2024
| @@ -147,7 +147,7 @@ class CallItemFactory @Inject constructor( | |||
| val userOfInterest = roomSummary.toMatrixItem() | |||
| val attributes = messageItemAttributesFactory.create(null, informationData, callback, reactionsSummaryEvents).let { | |||
| CallTileTimelineItem.Attributes( | |||
| isVoipSupported = vectorFeatures.tchapIsVoipSupported(session.sessionParams.homeServerUrl), | |||
| isCallSupported = vectorFeatures.tchapIsVisioSupported(session.sessionParams.homeServerUrl) || callKind.isVoiceCall, | |||
| callId = callId, | |||
There was a problem hiding this comment.
pourquoi ajouter la condition || callKind.isVoiceCall ? Cela va overrider tchapIsVisioSupported qui défini l'accès par HS non ? je suppose que callKind.isVoiceCall peut potentiellement être true alors qu'il n'est pas activé sur le HS
There was a problem hiding this comment.
callKind.isVoiceCall c'est pour les appels audios uniquement (pas la visio). On accepte l'appel entrant dans la timeline si il s'agit d'un appel audio (peu importe le HS) ou si on supporte la visio (pour le HS DINUM).
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
#1078
Motivation and context
Screenshots / GIFs
Tests
Tested devices
Checklist