Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple breaking changes #10

Merged
merged 12 commits into from
Oct 5, 2023
Merged

Multiple breaking changes #10

merged 12 commits into from
Oct 5, 2023

Conversation

tcarion
Copy link
Owner

@tcarion tcarion commented Mar 31, 2023

This PR brings several significant changes to Flexpart.jl:

  • The FlexpartDir object has been refactored to FlexpartSim
  • The NetCDFF version has been forced to 4.5.3 (solves issue Segmentation fault with [email protected] #9)
  • Ensemble runs works better
  • FlexExtract has been moved to a separate repo, since both modules can work independently, and very little code was shared between both.
  • The internal FlexpartOptions code has been move out of its own module

@codecov-commenter
Copy link

codecov-commenter commented Mar 31, 2023

Codecov Report

Patch coverage: 65.85% and project coverage change: +0.64 🎉

Comparison is base (d803176) 62.50% compared to head (6d517ed) 63.14%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #10      +/-   ##
==========================================
+ Coverage   62.50%   63.14%   +0.64%     
==========================================
  Files          10        9       -1     
  Lines         680      540     -140     
==========================================
- Hits          425      341      -84     
+ Misses        255      199      -56     
Impacted Files Coverage Δ
src/outputs.jl 36.00% <20.00%> (-1.50%) ⬇️
src/run.jl 38.46% <33.96%> (-13.01%) ⬇️
src/flexpartsim.jl 67.27% <67.27%> (ø)
src/abstracts.jl 64.28% <75.00%> (-4.95%) ⬇️
src/inputs.jl 84.61% <84.61%> (ø)
src/miscellaneous.jl 86.79% <100.00%> (ø)
src/options.jl 81.30% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tcarion tcarion merged commit 719d90d into main Oct 5, 2023
@tcarion tcarion deleted the dev branch October 5, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants