address comments

tc39 · Jan 8, 2025 · a473a2e · a473a2e
1 parent 73aa664
commit a473a2e
Show file tree

Hide file tree

Showing 11 changed files with 14 additions and 4 deletions.
diff --git a/test/built-ins/Iterator/prototype/drop/argument-validation-failure-closes-underlying.js b/test/built-ins/Iterator/prototype/drop/argument-validation-failure-closes-underlying.js
@@ -19,6 +19,7 @@ let closable = {
   },
   return() {
     closed = true;
+    return {};
   },
 };
 

diff --git a/test/built-ins/Iterator/prototype/every/argument-validation-failure-closes-underlying.js b/test/built-ins/Iterator/prototype/every/argument-validation-failure-closes-underlying.js
@@ -19,6 +19,7 @@ let closable = {
   },
   return() {
     closed = true;
+    return {};
   },
 };
 

diff --git a/test/built-ins/Iterator/prototype/filter/argument-validation-failure-closes-underlying.js b/test/built-ins/Iterator/prototype/filter/argument-validation-failure-closes-underlying.js
@@ -19,6 +19,7 @@ let closable = {
   },
   return() {
     closed = true;
+    return {};
   },
 };
 

diff --git a/test/built-ins/Iterator/prototype/find/argument-validation-failure-closes-underlying.js b/test/built-ins/Iterator/prototype/find/argument-validation-failure-closes-underlying.js
@@ -19,6 +19,7 @@ let closable = {
   },
   return() {
     closed = true;
+    return {};
   },
 };
 

diff --git a/test/built-ins/Iterator/prototype/flatMap/argument-validation-failure-closes-underlying.js b/test/built-ins/Iterator/prototype/flatMap/argument-validation-failure-closes-underlying.js
@@ -19,6 +19,7 @@ let closable = {
   },
   return() {
     closed = true;
+    return {};
   },
 };
 

diff --git a/test/built-ins/Iterator/prototype/forEach/argument-validation-failure-closes-underlying.js b/test/built-ins/Iterator/prototype/forEach/argument-validation-failure-closes-underlying.js
@@ -19,6 +19,7 @@ let closable = {
   },
   return() {
     closed = true;
+    return {};
   },
 };
 

diff --git a/test/built-ins/Iterator/prototype/map/argument-validation-failure-closes-underlying.js b/test/built-ins/Iterator/prototype/map/argument-validation-failure-closes-underlying.js
@@ -19,6 +19,7 @@ let closable = {
   },
   return() {
     closed = true;
+    return {};
   },
 };
 

diff --git a/test/built-ins/Iterator/prototype/reduce/argument-validation-failure-closes-underlying.js b/test/built-ins/Iterator/prototype/reduce/argument-validation-failure-closes-underlying.js
@@ -19,6 +19,7 @@ let closable = {
   },
   return() {
     closed = true;
+    return {};
   },
 };
 

diff --git a/test/built-ins/Iterator/prototype/reduce/non-callable-reducer.js b/test/built-ins/Iterator/prototype/reduce/non-callable-reducer.js
@@ -11,12 +11,12 @@ features: [iterator-helpers]
 flags: []
 ---*/
 let nonCallable = {};
-let iterator = (function* () {
+function* gen() {
   yield 1;
-})();
+}
 
 assert.throws(TypeError, function () {
-  iterator.reduce(nonCallable);
+  gen().reduce(nonCallable);
 });
 
-iterator.reduce(() => {});
+gen().reduce(() => {});
diff --git a/test/built-ins/Iterator/prototype/some/argument-validation-failure-closes-underlying.js b/test/built-ins/Iterator/prototype/some/argument-validation-failure-closes-underlying.js
@@ -19,6 +19,7 @@ let closable = {
   },
   return() {
     closed = true;
+    return {};
   },
 };
 

diff --git a/test/built-ins/Iterator/prototype/take/argument-validation-failure-closes-underlying.js b/test/built-ins/Iterator/prototype/take/argument-validation-failure-closes-underlying.js
@@ -19,6 +19,7 @@ let closable = {
   },
   return() {
     closed = true;
+    return {};
   },
 };
-Original file line number
+Diff line change
@@ Expand Up / @@ -19,6 +19,7 @@ let closable = { @@
       },
       return() {
         closed = true;
+        return {};
       },
     };
@@ Expand Down @@