Editorial: Implement next batch of editorial suggestions from Anba #3032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3032 +/- ##
=======================================
Coverage 95.70% 95.71%
=======================================
Files 21 21
Lines 9695 9704 +9
Branches 1742 1742
=======================================
+ Hits 9279 9288 +9
Misses 364 364
Partials 52 52 ☔ View full report in Codecov by Sentry. |
ptomato
force-pushed
the
editorial
branch
2 times, most recently
from
74e8fdb
to
737ecad
Compare
Ms2ger
approved these changes
Nov 11, 2024
See #3015, which posits that these assertions are hit in existing test262 tests.
These were holdovers from the old terminology. Closes: #3016
…step If the calendar ID is valid (ensured by the previous step) and the ISO date-time is within range (ensured by being in dateTime's internal slot) and the default constructor is used, then this can't throw. Closes: #3018
This AO takes a time duration, not an Internal Duration record. Closes: #3019
DivideTimeDuration is only called with certain divisors from the table of units, so there's no need for a general-purpose AO. (In the reference code, TimeDuration.prototype.fdiv() is still needed in a few places for implementation reasons having to do with floating-point numbers.) Closes: #3020
These are two lingering references to when time durations were a Record with a [[TotalNanoseconds]] field. Closes: #3021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3016, #3018, #3019, #3020, #3021