Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporal.PlainDateTime.prototype.withCalendar: CreateTemporalDateTime is infallible #3018

Closed
anba opened this issue Oct 23, 2024 · 0 comments
Closed

Temporal.PlainDateTime.prototype.withCalendar: CreateTemporalDateTime is infallible #3018

anba opened this issue Oct 23, 2024 · 0 comments
Assignees
@ptomato
Labels
editorial spec-text Specification text involved

Comments

@anba
Copy link
Contributor

anba commented Oct 23, 2024

Temporal.PlainDateTime.prototype.withCalendar, step 4:

  1. Return ? CreateTemporalDateTime(dateTime.[[ISODateTime]], calendar).

CreateTemporalDateTime is infallible, so ? should instead be !.
@ptomato ptomato self-assigned this Oct 26, 2024
@ptomato ptomato added spec-text Specification text involved editorial labels Oct 26, 2024
ptomato added a commit that referenced this issue Oct 31, 2024
@ptomato
Editorial: PlainDateTime.prototype.withCalendar cannot throw in last …
7d173e2 
…step

If the calendar ID is valid (ensured by the previous step) and the ISO
date-time is within range (ensured by being in dateTime's internal slot)
and the default constructor is used, then this can't throw.

Closes: #3018
@ptomato ptomato mentioned this issue Oct 31, 2024
Merged
ptomato added a commit that referenced this issue Nov 1, 2024
@ptomato
Editorial: PlainDateTime.prototype.withCalendar cannot throw in last …
b3a4e4b 
…step

If the calendar ID is valid (ensured by the previous step) and the ISO
date-time is within range (ensured by being in dateTime's internal slot)
and the default constructor is used, then this can't throw.

Closes: #3018
ptomato added a commit that referenced this issue Nov 11, 2024
@ptomato
Editorial: PlainDateTime.prototype.withCalendar cannot throw in last …
5adc64e 
…step

If the calendar ID is valid (ensured by the previous step) and the ISO
date-time is within range (ensured by being in dateTime's internal slot)
and the default constructor is used, then this can't throw.

Closes: #3018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ptomato ptomato

Labels
editorial spec-text Specification text involved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ptomato @anba