Normative: Fix bug with RelativeTimeFormat and DateTimeFormat not correctly passing "numberingSystem" option to NumberFormat #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
correctly passing "numberingSystem" option to NumberFormat
ben-allen
changed the title
ben-allen
added
has consensus
|
I believe this is presented to Oct TC39 meeting and still waiting for Mozilla to express their opinion. |
|
I believe they changed their conditional approval to approval at the start of the third day of plenary, but may have misunderstood. @codehag |
|
Received consensus at October 2024 TG1 meeting |
ben-allen
added
needs tests
has consensus (TG1)
|
Should we also add test to test262 to test this PR got implement correctly? |
|
yes, I'll be writing them soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #819
This fixes a spec bug; as far as I can tell, all actually existing implementations do this the right way rather than the specified way. Will change title to start with "Normative:" if this category of fix requires TG1 consensus.