-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editorial: Refactor ResolveLocale to simplify calls #849
Editorial: Refactor ResolveLocale to simplify calls #849
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am entirely for this change -- I've found the name _dataLocaleData_
to be borderline unreadable -- though I'm concerned that others might dislike losing the relationship between the name of the alias and the name of the [[DataLocale]]
slot. @ryzokuken @sffc @FrankYFTang
The word "resolved" to me means that the data went through some resolution algorithm, which I guess it did because of dataLocale. I think better would be to rename the variables to "resolvedLocale" and "resolvedLocaleData". But I don't have a strong preference. |
I wonder if we could remove the term "dataLocale" from the spec. I've created #853 as a possible alternative to this PR. |
…lvedLocaleData_ ...as in GetNumberFormatPattern.
…ta rather than its lookup key
f669ae0
to
3a03129
Compare
@ben-allen @ryzokuken This has extended to change the shape of the ResolveLocale return value and refactor an internal slot of NumberFormat and RelativeTimeFormat instances, so I'm requesting re-review before merging. |
This has been bugging me for quite a while.