Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: eliminate extra verbosity with %GeneratorPrototype% references #3460

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

michaelficarra
Copy link
Member

%GeneratorFunction.prototype.prototype% is just %GeneratorPrototype%

@linusg
Copy link
Member

linusg commented Oct 22, 2024

Can we also get rid of this bit? (same for %GeneratorFunction.prototype.prototype%)

image

@michaelficarra
Copy link
Member Author

@linusg I left those in intentionally because I find them helpful.

@linusg
Copy link
Member

linusg commented Oct 22, 2024

I agree that overall this is a useful hint but using intrinsic syntax for something that is never referenced again is confusing IMO.

FWIW this information is also available elsewhere:

image

@michaelficarra michaelficarra added the editor call to be discussed in the next editor call label Oct 23, 2024
@michaelficarra michaelficarra removed the editor call to be discussed in the next editor call label Oct 30, 2024
@michaelficarra michaelficarra added the ready to merge Editors believe this PR needs no further reviews, and is ready to land. label Oct 30, 2024
@ljharb ljharb force-pushed the prototype-prototype-prototype branch from a136b63 to 4c44bbe Compare October 31, 2024 05:57
@ljharb ljharb merged commit 4c44bbe into main Oct 31, 2024
9 checks passed
@ljharb ljharb deleted the prototype-prototype-prototype branch October 31, 2024 06:09
kimjg1119 pushed a commit to kimjg1119/ecma262 that referenced this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial change ready to merge Editors believe this PR needs no further reviews, and is ready to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants