Editorial: Don't allow writing NaN to frozen properties #3404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelficarra
approved these changes
Aug 26, 2024
syg
approved these changes
Aug 26, 2024
spec.html
Outdated
| @@ -12748,7 +12748,7 @@ <h1> | |||
| 1. If _Desc_ has a [[Set]] field and SameValue(_Desc_.[[Set]], _current_.[[Set]]) is *false*, return *false*. | |||
| 1. Else if _current_.[[Writable]] is *false*, then | |||
| 1. If _Desc_ has a [[Writable]] field and _Desc_.[[Writable]] is *true*, return *false*. | |||
| 1. If _Desc_ has a [[Value]] field and SameValue(_Desc_.[[Value]], _current_.[[Value]]) is *false*, return *false*. | |||
| 1. If _Desc_ has a [[Value]] field, return SameValue(_Desc_.[[Value]], _current_.[[Value]]). | |||
There was a problem hiding this comment.
Maybe a note to discourage future would-be refactorings?
There was a problem hiding this comment.
Unless you have a concrete suggestion on hand, I'd rather not delay this indefinitely. We could always add the note in a follow-up, right?
There was a problem hiding this comment.
NOTE: The following is not equivalent to returning false when SameValue returns false in the case of NaN.
There was a problem hiding this comment.
Nah, I don't like that wording. I'd say something like "the following step must not fall through to the property configuration steps below, even when SameValue returns true, because NaN values may be distinguishable".
There was a problem hiding this comment.
Suggested change
| 1. If _Desc_ has a [[Value]] field, return SameValue(_Desc_.[[Value]], _current_.[[Value]]). | |
| 1. NOTE: SameValue returns true for *NaN* values which may be distinguishable by other means. Returning here ensures that any existing property of _O_ remains unmodified. | |
| 1. If _Desc_ has a [[Value]] field, return SameValue(_Desc_.[[Value]], _current_.[[Value]]). |
gibson042
approved these changes
Aug 26, 2024
spec.html
Outdated
| @@ -12748,7 +12748,7 @@ <h1> | |||
| 1. If _Desc_ has a [[Set]] field and SameValue(_Desc_.[[Set]], _current_.[[Set]]) is *false*, return *false*. | |||
| 1. Else if _current_.[[Writable]] is *false*, then | |||
| 1. If _Desc_ has a [[Writable]] field and _Desc_.[[Writable]] is *true*, return *false*. | |||
| 1. If _Desc_ has a [[Value]] field and SameValue(_Desc_.[[Value]], _current_.[[Value]]) is *false*, return *false*. | |||
| 1. If _Desc_ has a [[Value]] field, return SameValue(_Desc_.[[Value]], _current_.[[Value]]). | |||
There was a problem hiding this comment.
Suggested change
| 1. If _Desc_ has a [[Value]] field, return SameValue(_Desc_.[[Value]], _current_.[[Value]]). | |
| 1. NOTE: SameValue returns true for *NaN* values which may be distinguishable by other means. Returning here ensures that any existing property of _O_ remains unmodified. | |
| 1. If _Desc_ has a [[Value]] field, return SameValue(_Desc_.[[Value]], _current_.[[Value]]). |
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Aug 27, 2024
…spidermonkey-reviewers,jandem `ValidateAndApplyPropertyDescriptor` was refactored in <tc39/ecma262#2468>, make sure our implementation follows the current spec text more closely. But also include the fix from <tc39/ecma262#3404>. Differential Revision: https://phabricator.services.mozilla.com/D220231
ErichDonGubler
pushed a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Aug 28, 2024
…spidermonkey-reviewers,jandem `ValidateAndApplyPropertyDescriptor` was refactored in <tc39/ecma262#2468>, make sure our implementation follows the current spec text more closely. But also include the fix from <tc39/ecma262#3404>. Differential Revision: https://phabricator.services.mozilla.com/D220231
bakkot
approved these changes
Oct 23, 2024
bakkot
added
the
ready to merge
If an implementation can produce distinguishable NaN values, then writing NaN values to a frozen (non-configurable and non-writable) property can be detectable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an implementation can produce distinguishable NaN values, then writing NaN values to a frozen (non-configurable and non-writable) property can be detectable.
This is a regression from #2468.