build: add so versioning when building shared library #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @waruqi review? |
waruqi
reviewed
Jul 17, 2023
waruqi
reviewed
Jul 17, 2023
|
#217 (comment) 構建 |
mochaaP
force-pushed
the
master
branch
2 times, most recently
from
bd86d23
to
fe55976
Compare
mochaaP
force-pushed
the
master
branch
5 times, most recently
from
e790a25
to
be62a47
Compare
waruqi
reviewed
Jul 17, 2023
| local srcheaderfile="" | ||
| local includedir="${_install_includedir_default}" | ||
| local includedir="\$(DESTDIR)${_install_includedir_default}" |
There was a problem hiding this comment.
why? 不要改。。./configure 是通用脚本，不光给 linux 构建用的。。不一定有设置 DESTDIR 不要直接用 DESTDIR
There was a problem hiding this comment.
你看上面 install_includedir_default 已經默認是 \$(PREFIX) 了
There was a problem hiding this comment.
如果是空的，会走到 INSTALLDIR:=\$(PREFIX)" 。。目前这边大部分时候安装 都是不设置 DESTDIR 的。。一直能 work
There was a problem hiding this comment.
INSTALLDIR 已經不存在了（因為 ${prefix} 被替換成 \$(PREFIX)）。
There was a problem hiding this comment.
INSTALLDIR 已經不存在了（因為
${prefix}被替換成\$(PREFIX)）。
那里也不要改。。
waruqi
reviewed
Jul 17, 2023
| echo "INSTALLDIR:=\$(PREFIX)" >> "${xmake_sh_makefile}" | ||
| echo "endif" >> "${xmake_sh_makefile}" | ||
| echo "endif" >> "${xmake_sh_makefile}" | ||
| echo "" >> "${xmake_sh_makefile}" |
waruqi
reviewed
Jul 17, 2023
| print "\t@mkdir -p ${_install_bindir_default}" >> "${xmake_sh_makefile}" | ||
| print "\t@cp -p ${targetfile} ${_install_bindir_default}/${filename}" >> "${xmake_sh_makefile}" | ||
| print "\t@mkdir -p \$(DESTDIR)${_install_bindir_default}" >> "${xmake_sh_makefile}" | ||
| print "\t@cp -p ${targetfile} \$(DESTDIR)${_install_bindir_default}/${filename}" >> "${xmake_sh_makefile}" |
Signed-off-by: Zephyr Lykos <[email protected]>
|
先放着吧，下个版本 有时间的话，我会搞下 |
Leave it alone, the next version, if I have time, I will do it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zephyr Lykos [email protected]
Fixes #214 (comment) for packaging guidelines & GNUInstallDirs compliance.
Tested on Linux x86_64, need feedback on other platforms.