Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve type definitions #162

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

manvydasu
Copy link
Contributor

@vercel
Copy link

vercel bot commented Jan 24, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tbleckert/react-select-search/ge3ozrqot
✅ Preview: https://react-select-search-git-fork-manvydasu-master.tbleckert.vercel.app

Base automatically changed from master to main January 29, 2021 07:41
@ramonsnir
Copy link

@tbleckert Hi, this wrong type is blocking us from using this library with TypeScript. Can you take a look and review it or merge it?

I see there's a small merge conflict, but it's very minor. If you need help with it because you're busy, I'll gladly help.

Thanks, we love this library (although using it with non-TS JS now 😄 )!

@AndrejGajdos
Copy link

@tbleckert any update on this?

@potatosenior
Copy link

Why is this still open?

@and-poulsen
Copy link

@tbleckert, this would be lovely to merge in 😌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants