-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add multi-currency dataCache #261
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeanPierreNell
previously approved these changes
Oct 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
JeanPierreNell
approved these changes
Oct 25, 2024
Sandy-at-Tazama
approved these changes
Oct 25, 2024
scott45
added a commit
that referenced
this pull request
Dec 3, 2024
* feat: add token middleware and env toggle * refactor: optional chaining * docs: typo * chore(deps): bump find-my-way from 8.2.0 to 8.2.2 Bumps [find-my-way](https://github.com/delvedor/find-my-way) from 8.2.0 to 8.2.2. - [Release notes](https://github.com/delvedor/find-my-way/releases) - [Commits](delvedor/find-my-way@v8.2.0...v8.2.2) --- updated-dependencies: - dependency-name: find-my-way dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * refactor: migrate from frms to tazama-lf (#245) * refactor: migrate from frms to tazama-lf * feat: Env/validation (#247) * feat: add env validation * test: mock envs * fix: update auth flag from service auth to node env * refactor: use same values for templating * refactor: apply cache option environment variable split * refactor: encapsulate environment variables * refactor: change directory path * test: mock the services of the library * refactor: bump tazama libraries * refactor: bump lib version * refactor: add auth requirement for production * feat: add multi-currency dataCache (#261) * feat(deps): use latest datacache from frms-coe-lib * feat: add xchgRate and use multi currency datacache * refactor(rename): use better naming for pending promises array * test: update datacache tests * docs: update message samples and activity diagram * feat: updated old links * refactor: bump frms-coe-lib * refactor: use lib schema save methods * refactor: remove collection based environment variables * test: update unit test mocks * docs: replace Redis with Valkey * feat: updated XchgRate object for Pain001 * bug: fixed spelling * build: update libs (#275) Co-authored-by: rtkay123 <[email protected]> * ci: sync workflows from central-workflows (#201) * ci: sync workflows from central-workflows Signed-off-by: Kyle Vorster <[email protected]> * ci: sync workflows from central-workflows Signed-off-by: Scott <[email protected]> * ci: sync workflows from central-workflows Signed-off-by: Scott <[email protected]> * ci: sync workflows from central-workflows Signed-off-by: Scott <[email protected]> --------- Co-authored-by: github-actions <[email protected]> Co-authored-by: Scott <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Len Bekker <[email protected]> Co-authored-by: Len Bekker <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Cebolenkosi Shezi <[email protected]> Co-authored-by: cshezi <[email protected]> Co-authored-by: Justus Ortlepp <[email protected]> Co-authored-by: Jean-Pierre <[email protected]> Co-authored-by: Jean-Pierre Nell <[email protected]> Co-authored-by: rtkay123 <[email protected]> Co-authored-by: rtkay123 <[email protected]> Co-authored-by: Kyle Vorster <[email protected]> Co-authored-by: github-actions <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did we change?
There datacache references were updated to include the latest from library. Updated schema for exchange rate properties (optional)
Why are we doing this?
Enable access to instdAmt, intrBkSttlmAmt and xchgRate downstream
How was it tested?