Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: apply cache option environment variable split #253

Merged
merged 1 commit into from
Oct 11, 2024
Merged

refactor: apply cache option environment variable split #253

merged 1 commit into from
Oct 11, 2024

Conversation

cshezi
Copy link
Contributor

@cshezi cshezi commented Oct 10, 2024 •
edited
Loading

SPDX-License-Identifier: Apache-2.0

What did we change?

We separated cache options variables

Why are we doing this?

To dedicate each to its own responsibility

How was it tested?

  • Locally
  • Development Environment
  • Not needed, changes very basic
  • Husky successfully run
  • Unit tests passing and Documentation done

@cshezi cshezi linked an issue Oct 10, 2024 that may be closed by this pull request
TMS - Split CACHE environment variables #252
Closed
@cshezi cshezi requested review from rtkay123 and scott45 October 10, 2024 14:25
@Sandy-at-Tazama Sandy-at-Tazama requested review from Sandy-at-Tazama and removed request for scott45 October 10, 2024 15:21
@cshezi cshezi merged commit 127ea78 into dev Oct 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scott45 scott45 scott45 approved these changes

@rtkay123 rtkay123 rtkay123 approved these changes

@Sandy-at-Tazama Sandy-at-Tazama Sandy-at-Tazama approved these changes

Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TMS - Split CACHE environment variables
4 participants
@cshezi @scott45 @rtkay123 @Sandy-at-Tazama