Improve webinterface #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wifimgr.py
Outdated
| </html> | ||
| """ % dict(ssid=ssid) | ||
| """.format(html_head, ssid) |
| @@ -280,8 +372,7 @@ def start(port=80): | |||
| client, addr = server_socket.accept() | |||
| print('client connected from', addr) | |||
| try: | |||
| client.settimeout(5.0) | |||
|
|
|||
| client.settimeout(15.0) | |||
There was a problem hiding this comment.
can you add a comment here why such a long timeout is needed?
There was a problem hiding this comment.
It fixed the timeout that some times occured on the not connected page.
| <li> | ||
| {ssid} | ||
| </li> | ||
| </a> |
There was a problem hiding this comment.
is this valid html?: a li text /li /a
or should it be rather?: li a text /a /li
There was a problem hiding this comment.
a is not display: block ( or similar ), so I see no problem.
fantom0005
approved these changes
Apr 28, 2019
|
@TilCreator hi there I'm trying to use this code, but I get |
|
I didn't touch these files for years, so sry, no clue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the web interface more mobile friendly and allows the input of custom SSIDs, so it is possible to connect to hidden WiFis.