This repository has been archived by the owner on Mar 17, 2021. It is now read-only.
Ensure that (internal) files are closed in {save,load}ConfigFile #1146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The {save,load}ConfigFile methods accept either a file name or a file object
as their argument. If a name is passed, a file object is internally created
and opened, but it is not closed. This may cause trouble. Make sure the
file is closed if it was internally created.
Note that, in order not to break backwards compatibility, the file
won't be closed if it was passed already as a file object (the
responsibility for closing lies in the opener)
cpascual
force-pushed
the
config_file_closing
branch
from
3cf939d
to
813f255
Compare
added 2 commits
September 14, 2020 14:38
As an attempt to work around an issue with installation of guiqwt in py37 with conda (which breaks the CI for the docs), update the environment in which the docs are built. Also, activate py38 tests in Travis
py38 tests are failing due to an stricter type checking in QObject.startTimer() Cast float argument to int to fix it.
|
@taurus-org/integrators : this is ready for review Note, the last 2 commits are cherry picks from develop added to fix the CI tests (due to unrelated issues). Only 813f255 needs to be reviewed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The {save,load}ConfigFile methods accept either a file name or a file object
as their argument. If a name is passed, a file object is internally created
and opened, but it is not closed. This may cause trouble. Make sure the
file is closed if it was internally created.
Note that, in order to maintain backwards compatibility, the file
won't be closed if it was passed already as a file object (the
responsibility for closing lies in the opener)