Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: changed Env.args to Env.args_os and use OsString instead of String #7876

Merged
merged 1 commit into from
Sep 21, 2023
Merged

refactor!: changed Env.args to Env.args_os and use OsString instead of String #7876

merged 1 commit into from
Sep 21, 2023

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Sep 21, 2023 •
edited
Loading

ref: #7756

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir amrbashir requested a review from a team as a code owner September 21, 2023 04:52
@amrbashir amrbashir mentioned this pull request Sep 21, 2023
Closed
14 tasks
@amrbashir amrbashir merged commit deea943 into dev Sep 21, 2023
@amrbashir amrbashir deleted the refactor/env-args-to-args-os branch September 21, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabianLars FabianLars FabianLars approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Roadmap
Status: 🔎 In audit
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amrbashir @FabianLars