Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n(zh-cn): translation Core Concepts #3088

Merged
merged 41 commits into from
Jan 14, 2025
Merged

i18n(zh-cn): translation Core Concepts #3088

merged 41 commits into from
Jan 14, 2025

Conversation

coffeemil
Copy link
Contributor

@coffeemil coffeemil commented Dec 27, 2024 •
edited
Loading

Translate into Chinese

Core Concepts:

  • Overview √
  • Tauri Architecture √
  • Process Model √
  • App Size √
  • Inter-Process Communication
    • Overview √

@coffeemil coffeemil requested a review from a team as a code owner December 27, 2024 04:45
@github-actions github-actions bot added i18n Is this related to translations? i18n: zh-cn Is this related to zh-cn translations? labels Dec 27, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 27, 2024 •
edited
Loading

✅ Deploy Preview for tauri-v2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 595d709
🔍 Latest deploy log https://app.netlify.com/sites/tauri-v2/deploys/6785fb68cb1f5600087f224d
😎 Deploy Preview https://deploy-preview-3088--tauri-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 87 (🔴 down 12 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@coffeemil coffeemil changed the title i18n(zh-cn): translation overview part i18n(zh-cn): translation Core Concepts Dec 27, 2024
GuoJikun
GuoJikun reviewed Jan 3, 2025
View reviewed changes
Copy link
Contributor

@GuoJikun GuoJikun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicks here and there and should be good to go!

src/content/docs/zh-cn/concept/Inter-Process Communication/index.mdx Outdated Show resolved Hide resolved
src/content/docs/zh-cn/concept/Inter-Process Communication/index.mdx Outdated Show resolved Hide resolved
src/content/docs/zh-cn/concept/Inter-Process Communication/index.mdx Outdated Show resolved Hide resolved
src/content/docs/zh-cn/concept/Inter-Process Communication/index.mdx Outdated Show resolved Hide resolved
src/content/docs/zh-cn/concept/Inter-Process Communication/index.mdx Outdated Show resolved Hide resolved
src/content/docs/zh-cn/concept/process-model.md Outdated Show resolved Hide resolved
src/content/docs/zh-cn/concept/size.mdx Outdated Show resolved Hide resolved
src/content/docs/zh-cn/concept/Inter-Process Communication/index.mdx Outdated Show resolved Hide resolved
src/content/docs/zh-cn/concept/architecture.mdx Outdated Show resolved Hide resolved
src/content/docs/zh-cn/concept/architecture.mdx Outdated Show resolved Hide resolved
coffeemil and others added 15 commits January 9, 2025 17:39
@coffeemil @GuoJikun
Update src/content/docs/zh-cn/concept/Inter-Process Communication/ind…
750f414 
…ex.mdx

Co-authored-by: _zhiqiu <[email protected]>
@coffeemil @GuoJikun
Update src/content/docs/zh-cn/concept/Inter-Process Communication/ind…
efb0e36 
…ex.mdx

Co-authored-by: _zhiqiu <[email protected]>
@coffeemil @GuoJikun
Update src/content/docs/zh-cn/concept/Inter-Process Communication/ind…
1d28677 
…ex.mdx

Co-authored-by: _zhiqiu <[email protected]>
@coffeemil @GuoJikun
Update src/content/docs/zh-cn/concept/Inter-Process Communication/ind…
2b20f32 
…ex.mdx

Co-authored-by: _zhiqiu <[email protected]>
@coffeemil @GuoJikun
Update src/content/docs/zh-cn/concept/Inter-Process Communication/ind…
bdb9de2 
…ex.mdx

Co-authored-by: _zhiqiu <[email protected]>
@coffeemil @GuoJikun
Update src/content/docs/zh-cn/concept/process-model.md
f387f92 
Co-authored-by: _zhiqiu <[email protected]>
@coffeemil @GuoJikun
Update src/content/docs/zh-cn/concept/size.mdx
781fa04 
Co-authored-by: _zhiqiu <[email protected]>
@coffeemil @GuoJikun
Update src/content/docs/zh-cn/concept/Inter-Process Communication/ind…
609324d 
…ex.mdx

Co-authored-by: _zhiqiu <[email protected]>
@coffeemil @GuoJikun
Update src/content/docs/zh-cn/concept/architecture.mdx
61a24ee 
Co-authored-by: _zhiqiu <[email protected]>
@coffeemil @GuoJikun
Update src/content/docs/zh-cn/concept/architecture.mdx
e2fe510 
Co-authored-by: _zhiqiu <[email protected]>
@coffeemil @GuoJikun
Update src/content/docs/zh-cn/concept/Inter-Process Communication/ind…
270898c 
…ex.mdx

Co-authored-by: _zhiqiu <[email protected]>
@coffeemil @GuoJikun
Update src/content/docs/zh-cn/concept/Inter-Process Communication/ind…
dc54e55 
…ex.mdx

Co-authored-by: _zhiqiu <[email protected]>
@coffeemil @GuoJikun
Update src/content/docs/zh-cn/concept/Inter-Process Communication/ind…
26f8d78 
…ex.mdx

Co-authored-by: _zhiqiu <[email protected]>
@coffeemil @GuoJikun
Update src/content/docs/zh-cn/concept/architecture.mdx
f5cb9b8 
Co-authored-by: _zhiqiu <[email protected]>
@coffeemil @GuoJikun
Update src/content/docs/zh-cn/concept/architecture.mdx
e35c410 
Co-authored-by: _zhiqiu <[email protected]>
coffeemil
coffeemil commented Jan 9, 2025
View reviewed changes
Copy link
Contributor Author

@coffeemil coffeemil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aceept

@dreyfus92
Copy link
Member

hey @GuoJikun can you kindly give a final review to this when you get a chance? 🫣

@GuoJikun
Copy link
Contributor

GuoJikun commented Jan 13, 2025 •
edited
Loading

can you kindly give a final review to this when you get a chance?

Yes.
But I'm not very clear about the review process.
What should I do?

@dreyfus92
Copy link
Member

You could you take a moment to go over the document and see if any suggestions were missed or if there are any typos. If everything looks good, you can go ahead and add 'LGTM' 😊.

@coffeemil
Copy link
Contributor Author

That doesn't sound very easy , thank you for reviewing officer 😊

GuoJikun
GuoJikun reviewed Jan 13, 2025
View reviewed changes
src/content/docs/zh-cn/concept/process-model.md Outdated Show resolved Hide resolved
src/content/docs/zh-cn/concept/process-model.md Outdated Show resolved Hide resolved
src/content/docs/zh-cn/concept/process-model.md Outdated Show resolved Hide resolved
src/content/docs/zh-cn/concept/process-model.md Outdated Show resolved Hide resolved
coffeemil and others added 7 commits January 13, 2025 17:00
@coffeemil @GuoJikun
Update src/content/docs/zh-cn/concept/process-model.md
78bb9a1 
Co-authored-by: _zhiqiu <[email protected]>
@coffeemil @GuoJikun
Update src/content/docs/zh-cn/concept/process-model.md
1fd380c 
Co-authored-by: _zhiqiu <[email protected]>
@coffeemil @GuoJikun
Update src/content/docs/zh-cn/concept/process-model.md
0372742 
Co-authored-by: _zhiqiu <[email protected]>
@coffeemil @GuoJikun
Update src/content/docs/zh-cn/concept/process-model.md
fea9236 
Co-authored-by: _zhiqiu <[email protected]>
@coffeemil @GuoJikun
Update src/content/docs/zh-cn/concept/Inter-Process Communication/ind…
a68dd23 
…ex.mdx

Co-authored-by: _zhiqiu <[email protected]>
@coffeemil @GuoJikun
Update src/content/docs/zh-cn/concept/Inter-Process Communication/ind…
406ba55 
…ex.mdx

Co-authored-by: _zhiqiu <[email protected]>
@coffeemil @GuoJikun
Update src/content/docs/zh-cn/concept/process-model.md
a651767 
Co-authored-by: _zhiqiu <[email protected]>
@GuoJikun
Copy link
Contributor

LGTM @dreyfus92

dreyfus92
dreyfus92 approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you both! 🫡

@dreyfus92
Copy link
Member

woops, @coffeemil can you run prettier with --write to fix the issue on the CI/CD check?

@coffeemil
Copy link
Contributor Author

Let me try

@coffeemil
Copy link
Contributor Author

hey @dreyfus92, fixing is done!

@FabianLars FabianLars merged commit a2239d2 into tauri-apps:v2 Jan 14, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuoJikun GuoJikun GuoJikun left review comments

@dreyfus92 dreyfus92 dreyfus92 approved these changes

Assignees

@coffeemil coffeemil

Labels
i18n: zh-cn Is this related to zh-cn translations? i18n Is this related to translations?
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@coffeemil @dreyfus92 @GuoJikun @FabianLars