-
Notifications
You must be signed in to change notification settings - Fork 677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nix/NixOS Requirements and Documentation #2413
base: v2
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for tauri-v2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
continue more tomorrow. |
Working on a builder for tauri at https://github.com/eveeifyeve/buildtauriapp. |
So I am working on the builder to make it easy to build tauri apps |
Working on converting it all to stdenv from rustplatform. |
In my roadmap https://github.com/Eveeifyeve/buildTauriApp/issues/1 |
today I am going to push more documentation and see if I can get it working on my end and provide a build template to get started to build tauri for desktop only I haven't gotten around mobile. |
I am looking to add more documentation about packaging for nix/nixos using the hook: NixOS/nixpkgs#335751 |
Is it okay to rebase @simonhyll to fix this merge confict? |
Fix it however you prefer. rebase or "normal" merge, we don't really care :) |
I am waiting for this: NixOS/nixpkgs#335751 to be on all unstable channels before I make docs about building for nix/nixos |
fbfe67b
to
29c6a11
Compare
I am rethinking of this pr I am going to do a nix overhaul. |
a8098c0
to
8b9152a
Compare
I think it's ready it, but the android and ios parts haven't been tested. |
846fe42
to
325a08d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of this is really good, but a lot of it feels like overkill. Many of the instructions here already apply to Nix/NixOS if you know how to use it (like what dependencies to install, how to install them, etc) and others are so exclusive to NixOS that I don't think upstream documentation is the place for it
I would recommend moving much of this to wiki.nixos.org, as it will have a lot more support and recognition from its target audience there. Nix/NixOS should be treated mostly the same as other distros here IMO
tauri-apps#2413 (comment) Co-authored-by: seth <[email protected]>
Also would it be okay to squash the commits in this pr? |
We always squash merge (almost) all PRs :) |
Co-authored-by: seth <[email protected]>
Co-authored-by: seth <[email protected]>
Co-authored-by: seth <[email protected]>
Co-authored-by: seth <[email protected]>
Co-authored-by: seth <[email protected]>
Co-authored-by: seth <[email protected]>
Co-authored-by: seth <[email protected]>
Co-authored-by: seth <[email protected]>
Co-authored-by: seth <[email protected]>
Co-authored-by: seth <[email protected]>
tauri-apps#2413 (comment) Co-authored-by: seth <[email protected]>
55c6394
to
a201d12
Compare
Okay good cause this pr has too many commits. |
|
||
buildInputs = | ||
with pkgs; | ||
[ openssl ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@getchoo for some reason libiconv
is required maybe for plugins?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What plugins specifically? It'd be nice to note it
I also imagine that would be a macOS exclusive dependency; libiconv is hardly ever used on Linux
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have to test to see which plugins require it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will investigate and create a minimal environment.
Because of an own section for nix/nixos and darwin nix users should know where nix/nixos section and be able to navigate to the documentation
Because I don't want to have anymore flake templates on my github neither maintain it there, so that's why I am linking to a good example of how to use the above shell.nix in a flake
@Eveeifyeve is this ready? |
} | ||
``` | ||
|
||
This section has been moved Nix/NixOS to a dedicated section [here](#nixnixos) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not finished as I got to resolve #2413 (comment). I am also going to mark this pr as a draft in a sec because of this. |
Description
Note This Is English Only! Translation will be needed for i18n support
This PR Adds the necessary requirements for Nix(Package Manager) & NixOS(Linux Distro)