Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nix/NixOS Requirements and Documentation #2413

Draft
wants to merge 32 commits into
base: v2
Choose a base branch
from

Conversation

Eveeifyeve
Copy link

Description

Note This Is English Only! Translation will be needed for i18n support

This PR Adds the necessary requirements for Nix(Package Manager) & NixOS(Linux Distro)

Copy link

netlify bot commented Jul 15, 2024

Deploy Preview for tauri-v2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 6d5756d
🔍 Latest deploy log https://app.netlify.com/sites/tauri-v2/deploys/679d1825309e4c00070ad35c
😎 Deploy Preview https://deploy-preview-2413--tauri-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (🟢 up 12 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@Eveeifyeve
Copy link
Author

continue more tomorrow.

@simonhyll simonhyll added this to the Version 2.0 milestone Jul 19, 2024
@simonhyll simonhyll added the bug Does it fix inaccurate content or fix a bug? label Jul 19, 2024
@Eveeifyeve
Copy link
Author

Eveeifyeve commented Jul 20, 2024

Working on a builder for tauri at https://github.com/eveeifyeve/buildtauriapp.

@Eveeifyeve
Copy link
Author

So I am working on the builder to make it easy to build tauri apps

@Eveeifyeve Eveeifyeve changed the title Nix & NixOS Reqiurements Nix/NixOS Reqiurements and Documentation Jul 30, 2024
@Eveeifyeve
Copy link
Author

Working on converting it all to stdenv from rustplatform.

@Eveeifyeve
Copy link
Author

@Eveeifyeve
Copy link
Author

today I am going to push more documentation and see if I can get it working on my end and provide a build template to get started to build tauri for desktop only I haven't gotten around mobile.

@Eveeifyeve
Copy link
Author

Eveeifyeve commented Sep 2, 2024

I am looking to add more documentation about packaging for nix/nixos using the hook: NixOS/nixpkgs#335751

@Eveeifyeve
Copy link
Author

Is it okay to rebase @simonhyll to fix this merge confict?

@FabianLars
Copy link
Member

Fix it however you prefer. rebase or "normal" merge, we don't really care :)

@Eveeifyeve
Copy link
Author

I am waiting for this: NixOS/nixpkgs#335751 to be on all unstable channels before I make docs about building for nix/nixos

@Eveeifyeve
Copy link
Author

I am rethinking of this pr I am going to do a nix overhaul.

@Eveeifyeve
Copy link
Author

I think it's ready it, but the android and ios parts haven't been tested.

@Eveeifyeve Eveeifyeve marked this pull request as ready for review October 2, 2024 18:13
@Eveeifyeve Eveeifyeve requested a review from a team as a code owner October 2, 2024 18:13
Copy link

@getchoo getchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of this is really good, but a lot of it feels like overkill. Many of the instructions here already apply to Nix/NixOS if you know how to use it (like what dependencies to install, how to install them, etc) and others are so exclusive to NixOS that I don't think upstream documentation is the place for it

I would recommend moving much of this to wiki.nixos.org, as it will have a lot more support and recognition from its target audience there. Nix/NixOS should be treated mostly the same as other distros here IMO

src/content/docs/distribute/index.mdx Outdated Show resolved Hide resolved
src/content/docs/start/prerequisites.mdx Outdated Show resolved Hide resolved
src/content/docs/start/prerequisites.mdx Outdated Show resolved Hide resolved
src/content/docs/start/prerequisites.mdx Outdated Show resolved Hide resolved
src/content/docs/start/prerequisites.mdx Outdated Show resolved Hide resolved
src/content/docs/start/prerequisites.mdx Outdated Show resolved Hide resolved
src/content/docs/start/prerequisites.mdx Outdated Show resolved Hide resolved
src/content/docs/start/prerequisites.mdx Outdated Show resolved Hide resolved
src/content/docs/start/prerequisites.mdx Outdated Show resolved Hide resolved
src/content/docs/start/prerequisites.mdx Outdated Show resolved Hide resolved
Eveeifyeve added a commit to Eveeifyeve/tauri-docs that referenced this pull request Oct 3, 2024
@Eveeifyeve Eveeifyeve requested a review from getchoo October 3, 2024 19:09
@dreyfus92 dreyfus92 changed the title Nix/NixOS Reqiurements and Documentation Nix/NixOS Requirements and Documentation Oct 3, 2024
@Eveeifyeve
Copy link
Author

Also would it be okay to squash the commits in this pr?

@FabianLars
Copy link
Member

We always squash merge (almost) all PRs :)

@Eveeifyeve
Copy link
Author

We always squash merge (almost) all PRs :)

Okay good cause this pr has too many commits.


buildInputs =
with pkgs;
[ openssl ]
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@getchoo for some reason libiconv is required maybe for plugins?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What plugins specifically? It'd be nice to note it

I also imagine that would be a macOS exclusive dependency; libiconv is hardly ever used on Linux

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have to test to see which plugins require it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will investigate and create a minimal environment.

Because of an own section for nix/nixos and darwin nix users should know where nix/nixos section and be able to navigate to the documentation
Because I don't want to have anymore flake templates on my github neither maintain it there, so that's why I am linking to a good example of how to use the above shell.nix in a flake
@vasfvitor
Copy link
Contributor

@Eveeifyeve is this ready?

}
```

This section has been moved Nix/NixOS to a dedicated section [here](#nixnixos)
Copy link
Contributor

@vasfvitor vasfvitor Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer if you wrap it into a :::info aside, as of now it kinda mixed with the text content right after it. Ofc if you have a better idea than aside it could work.
image

@Eveeifyeve
Copy link
Author

Eveeifyeve commented Feb 4, 2025

@Eveeifyeve is this ready?

This is not finished as I got to resolve #2413 (comment).

I am also going to mark this pr as a draft in a sec because of this.

@Eveeifyeve Eveeifyeve marked this pull request as draft February 4, 2025 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Does it fix inaccurate content or fix a bug?
Projects
Status: 🏗️ In progress
Development

Successfully merging this pull request may close these issues.

[feat] upstream nix requirements to nixpkgs
5 participants