Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(prerequisites): remove duplicated env path of NDK_HOME #2265

Merged
merged 4 commits into from
Jun 9, 2024

Conversation

zennolux
Copy link
Contributor

@zennolux zennolux commented Jun 8, 2024

What kind of changes does this PR include?

remove duplicated env path of NDK_HOME

Description

When setting the Android environment of NDK_HOME on Windows, the variable $VERSION returns the full path already, so there is no need to add the duplicated path before $VERSION.

Before:
image

After:
image

The varible $VERSION returns the full path alreadly.
@zennolux zennolux requested a review from a team as a code owner June 8, 2024 16:14
Copy link

netlify bot commented Jun 8, 2024

Deploy Preview for tauri-v2 ready!

Name Link
🔨 Latest commit 3718b7a
🔍 Latest deploy log https://app.netlify.com/sites/tauri-v2/deploys/6665878951e188000883da90
😎 Deploy Preview https://deploy-preview-2265--tauri-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@FabianLars
Copy link
Member

FabianLars commented Jun 8, 2024

Hmm, it does only print the version for me so the current docs is what's required on my end, i wonder what's going on 🤔
What does make it work me like it works for me is changing the env set command to this:

[System.Environment]::SetEnvironmentVariable("NDK_HOME", $VERSION.FullName, "User")

Not sure what the best path forward here is...

@zennolux
Copy link
Contributor Author

zennolux commented Jun 9, 2024

[System.Environment]::SetEnvironmentVariable("NDK_HOME", $VERSION.FullName, "User")

This also works for me.

And replacing -Path with -Name makes sense in my test.

image

@FabianLars
Copy link
Member

thank you

@FabianLars FabianLars merged commit 66f486c into tauri-apps:v2 Jun 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants