Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: turns theme selector into a button instead of a dropdown #2256

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

simonhyll
Copy link
Contributor

Stole this from one of my other projects because I think it's much nicer than having a dropdown for theme selection when we only have 2 themes, dark and light.

@simonhyll simonhyll added the enhancement Does it add or improve content? label Jun 6, 2024
@simonhyll simonhyll added this to the Version 2.x milestone Jun 6, 2024
@simonhyll simonhyll self-assigned this Jun 6, 2024
@simonhyll simonhyll requested a review from a team as a code owner June 6, 2024 14:39
Copy link

netlify bot commented Jun 6, 2024

Deploy Preview for tauri-v2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit b445284
🔍 Latest deploy log https://app.netlify.com/sites/tauri-v2/deploys/6661ca2c93dcba000889faaa
😎 Deploy Preview https://deploy-preview-2256--tauri-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (🟢 up 2 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@vasfvitor vasfvitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yeaahhh

@simonhyll simonhyll merged commit 151fa08 into tauri-apps:v2 Jun 6, 2024
8 checks passed
@simonhyll simonhyll deleted the feat/theme-selector branch June 6, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Does it add or improve content?
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants