-
Notifications
You must be signed in to change notification settings - Fork 677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: d2 diagrams, process model #2202
Conversation
✅ Deploy Preview for tauri-v2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you think it's worth to add a note to CONTRIBUTING.md mentioning the process of adding new diagrams?
we could even open a new good first issue to replace our current diagrams with d2 |
Yea that's probably a good idea, I'll add a note about it to the PR
Mmmmmmaybe, depends on how quick I get done updating some of the diagrams x) If I get bored we can for sure make good first issues for it |
Requires that d2 is installed on the machine, there's no NPM dependency we can add for that. I wouldn't say that's too big a deal however seeing as we're currently pushing images manually anyway, now we'd just have a nice tool for doing so.
https://astro-d2.vercel.app/