Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: d2 diagrams, process model #2202

Merged
merged 6 commits into from
May 24, 2024
Merged

Conversation

simonhyll
Copy link
Contributor

@simonhyll simonhyll commented May 24, 2024

Requires that d2 is installed on the machine, there's no NPM dependency we can add for that. I wouldn't say that's too big a deal however seeing as we're currently pushing images manually anyway, now we'd just have a nice tool for doing so.

https://astro-d2.vercel.app/

Copy link

netlify bot commented May 24, 2024

Deploy Preview for tauri-v2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit f9af52f
🔍 Latest deploy log https://app.netlify.com/sites/tauri-v2/deploys/6650f48e6fa64c0008452ea1
😎 Deploy Preview https://deploy-preview-2202--tauri-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

socket-security bot commented May 24, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] None +3 106 kB hideoo

View full report↗︎

@simonhyll simonhyll added this to the Version 2.x milestone May 24, 2024
@simonhyll simonhyll added the enhancement Does it add or improve content? label May 24, 2024
@simonhyll simonhyll self-assigned this May 24, 2024
@simonhyll simonhyll changed the title fix: adding process model feat: d2 diagrams, process model May 24, 2024
@simonhyll simonhyll requested a review from vasfvitor May 24, 2024 19:36
@simonhyll simonhyll marked this pull request as ready for review May 24, 2024 19:37
@simonhyll simonhyll requested a review from a team as a code owner May 24, 2024 19:37
Copy link
Contributor

@vasfvitor vasfvitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you think it's worth to add a note to CONTRIBUTING.md mentioning the process of adding new diagrams?

@vasfvitor
Copy link
Contributor

we could even open a new good first issue to replace our current diagrams with d2

@simonhyll
Copy link
Contributor Author

do you think it's worth to add a note to CONTRIBUTING.md mentioning the process of adding new diagrams?

Yea that's probably a good idea, I'll add a note about it to the PR

we could even open a new good first issue to replace our current diagrams with d2

Mmmmmmaybe, depends on how quick I get done updating some of the diagrams x) If I get bored we can for sure make good first issues for it

@simonhyll simonhyll merged commit 0b9d4c5 into tauri-apps:v2 May 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Does it add or improve content?
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants