Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix incorrect permissions #2149

Merged
merged 3 commits into from
May 14, 2024
Merged

chore: fix incorrect permissions #2149

merged 3 commits into from
May 14, 2024

Conversation

amrbashir
Copy link
Member

What kind of changes does this PR include?

  • Minor content fixes (broken links, typos, etc.)
  • New or updated content
  • Translated content
  • Changes to the docs site code
  • Something else!

Description

  • Closes #
  • What does this PR change? Give us a brief description.
  • Did you change something visual? A before/after screenshot can be helpful.

@amrbashir amrbashir requested a review from a team as a code owner May 14, 2024 16:27
Copy link

netlify bot commented May 14, 2024

Deploy Preview for tauri-v2 ready!

Name Link
🔨 Latest commit 771812e
🔍 Latest deploy log https://app.netlify.com/sites/tauri-v2/deploys/66439d793305a4000983f5bf
😎 Deploy Preview https://deploy-preview-2149--tauri-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@vasfvitor
Copy link
Contributor

vasfvitor commented May 14, 2024

@amrbashir these links seems to be breaking but I can't find out why, same has happened on another PR https://www.github.com/tauri-apps/tauri-docs/pull/2137 but it built locally. Oddly, another PR with same diff, didn't break

@amrbashir
Copy link
Member Author

I have no idea tbh 😅

@FabianLars
Copy link
Member

i see the same error locally after cloning the repo from scratch

@FabianLars
Copy link
Member

that was my bad 😩

@vasfvitor vasfvitor merged commit d383900 into v2 May 14, 2024
7 checks passed
@vasfvitor vasfvitor deleted the amrbashir-patch-1 branch May 14, 2024 17:28
vasfvitor pushed a commit to vasfvitor/tauri-docs that referenced this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants