Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a guide on making a bespoke Titlebar component #2135

Open
wants to merge 5 commits into
base: v2
Choose a base branch
from

Conversation

dan-myles
Copy link
Contributor

What kind of changes does this PR include?

  • New or updated content
  • Changes to the docs site code

Description

This PR adds a new guide that goes in-depth on making a custom titlebar for Tauri applications.
It also goes over conditional rendering using some plugins. I think it'll be a great addition to the
"learn" section, but can be moved around, of course.

I've also added a "bun" command to the command tabs component, needed it throughout the guide.

@dan-myles dan-myles requested a review from a team as a code owner May 10, 2024 01:32
Copy link

netlify bot commented May 10, 2024

Deploy Preview for tauri-v2 failed.

Built without sensitive environment variables

Name Link
🔨 Latest commit 39a7988
🔍 Latest deploy log https://app.netlify.com/sites/tauri-v2/deploys/66b8f5761c659700080056ca

@dan-myles
Copy link
Contributor Author

Here is a link to the deployment preview and the specific article that was written:
https://deploy-preview-2135--tauri-v2.netlify.app/learn/custom-titlebar/

@simonhyll simonhyll added this to the Version 2.x milestone May 21, 2024
@simonhyll simonhyll added enhancement Does it add or improve content? tauri 2.0 docs and removed tauri 2.0 docs labels May 21, 2024
@@ -7,9 +7,10 @@ interface Props {
yarn?: string;
pnpm?: string;
cargo?: string;
bun?: string;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's cool to see this article and the site preview. Looks nice :) But I think you will have an easier time getting the article merged if you don't also include this unrelated change in the same PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're right, and now it isn't necessary anymore as we already implemented bun support on CommandTabs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, this change was not meant to be included in the original PR. Will update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Does it add or improve content?
Projects
Status: 🏗️ In progress
Development

Successfully merging this pull request may close these issues.

4 participants