Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make android ndk path reliable #2081

Merged

Conversation

alex-crabnebula
Copy link
Contributor

What kind of changes does this PR include?

  • Minor content fixes (broken links, typos, etc.): making the setup of the Android NDK directory more reliable against version updates.

Description

Previously, a fixed version was used to reference the NDK directory. This is obviously unreliable when the NDK version changes, so a little change was introduced to read the subdirectory directly.

@alex-crabnebula alex-crabnebula requested a review from a team as a code owner April 22, 2024 09:35
Copy link

netlify bot commented Apr 22, 2024

Deploy Preview for tauri-v2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit b8a5d25
🔍 Latest deploy log https://app.netlify.com/sites/tauri-v2/deploys/6629fe0ae984400008a64778
😎 Deploy Preview https://deploy-preview-2081--tauri-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@alex-crabnebula alex-crabnebula force-pushed the feat/reliable-android-ndk-path branch from 3e00936 to 12034be Compare April 22, 2024 09:50
Copy link
Contributor

@vasfvitor vasfvitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh and there was a overhaul on the docs file structure, that's why the pr has conflicts now

src/content/docs/guides/prerequisites/index.mdx Outdated Show resolved Hide resolved
@alex-crabnebula alex-crabnebula force-pushed the feat/reliable-android-ndk-path branch from 12034be to b0ba818 Compare April 24, 2024 07:49
@alex-crabnebula alex-crabnebula force-pushed the feat/reliable-android-ndk-path branch from b0ba818 to 16e26a4 Compare April 24, 2024 19:44
Copy link
Contributor

@vasfvitor vasfvitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending @dreyfus92 review

@alex-crabnebula alex-crabnebula force-pushed the feat/reliable-android-ndk-path branch from 16e26a4 to 3289297 Compare April 25, 2024 06:46
@alex-crabnebula alex-crabnebula force-pushed the feat/reliable-android-ndk-path branch from 3289297 to b8a5d25 Compare April 25, 2024 06:54
Copy link
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@FabianLars FabianLars merged commit cd3258f into tauri-apps:v2 Apr 25, 2024
7 checks passed
@alex-crabnebula alex-crabnebula deleted the feat/reliable-android-ndk-path branch April 25, 2024 11:33
vasfvitor pushed a commit to vasfvitor/tauri-docs that referenced this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants