-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make android ndk path reliable #2081
feat: make android ndk path reliable #2081
Conversation
✅ Deploy Preview for tauri-v2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
3e00936
to
12034be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh and there was a overhaul on the docs file structure, that's why the pr has conflicts now
12034be
to
b0ba818
Compare
b0ba818
to
16e26a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pending @dreyfus92 review
16e26a4
to
3289297
Compare
3289297
to
b8a5d25
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
What kind of changes does this PR include?
Description
Previously, a fixed version was used to reference the NDK directory. This is obviously unreliable when the NDK version changes, so a little change was introduced to read the subdirectory directly.