Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(features): hide authenticator #1915

Merged
merged 3 commits into from
Mar 4, 2024

Conversation

dreyfus92
Copy link
Member

@dreyfus92 dreyfus92 commented Mar 4, 2024

What kind of changes does this PR include?

  • Changes to the docs site code

Description

  • Closes # N/A
  • What does this PR change? Give us a brief description.
    As discussed with Fabian in Discord this plugin won't get a stable release anytime soon.

@dreyfus92 dreyfus92 requested a review from a team as a code owner March 4, 2024 14:49
Copy link

netlify bot commented Mar 4, 2024

Deploy Preview for tauri-docs-starlight ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 69580f2
🔍 Latest deploy log https://app.netlify.com/sites/tauri-docs-starlight/deploys/65e5e389f56b1b000873070d
😎 Deploy Preview https://deploy-preview-1915--tauri-docs-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@vasfvitor vasfvitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't renaming to _authenticator.mdx be better? With the current approach the page will still be rendered if I understand correctly

edit: yeah https://deploy-preview-1915--tauri-docs-starlight.netlify.app/features/authenticator/

@dreyfus92
Copy link
Member Author

actually yeah, forgot about using the dunder method to skip bundling. this is way better.

Copy link
Contributor

@vasfvitor vasfvitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfection!

@vasfvitor vasfvitor merged commit 66e01e0 into tauri-apps:next Mar 4, 2024
7 checks passed
@dreyfus92 dreyfus92 deleted the feat/authenticator branch April 30, 2024 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants