Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Node.js setup instructions #1903

Merged
merged 7 commits into from
Mar 4, 2024
Merged

Conversation

vasfvitor
Copy link
Contributor

Wrote this aiming #1864

After we shape this I'll open a PR to the dev branch

page is : "guides/prerequisites"

@vasfvitor vasfvitor requested a review from a team as a code owner March 2, 2024 22:22
Copy link

netlify bot commented Mar 2, 2024

Deploy Preview for tauri-docs-starlight ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit db474ff
🔍 Latest deploy log https://app.netlify.com/sites/tauri-docs-starlight/deploys/65e6306be74f3a0008c384a5
😎 Deploy Preview https://deploy-preview-1903--tauri-docs-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job @vasfvitor, I left you a couple of nits, let me know what you think 😁

src/content/docs/guides/prerequisites/index.mdx Outdated Show resolved Hide resolved
src/content/docs/guides/prerequisites/index.mdx Outdated Show resolved Hide resolved
src/content/docs/guides/prerequisites/index.mdx Outdated Show resolved Hide resolved
@vasfvitor
Copy link
Contributor Author

@dreyfus92 I think now it's clearer :)

I added the "next" section, could you take a look? 3cbe439

Copy link
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should do the work, thank you @vasfvitor 😁

@dreyfus92 dreyfus92 merged commit d4456d9 into tauri-apps:next Mar 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants