-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Plugin permissions component #1890
Conversation
✅ Deploy Preview for tauri-v2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Added the plugin identifier to the permission id in tauri-apps/tauri#10113 so you should be able to use this somehow. Also open to improve the generated tables. |
f60dba1
to
c44291f
Compare
Hey @vasfvitor can you update the tauri and plugin workspace submodule (the plugins default permissions and the upstream PR are merged)? |
Also wondering how we want to translate the auto generated content and content based on the plugins permissions. Maybe we use some auto translation for these generated sections? |
@tillmann-crabnebula it looks https://github.com/tauri-apps/plugins-workspace/blob/v2/plugins/autostart/permissions/autogenerated/reference.md broken? I'll update the submodules
this is something I've been wondering since. And somehow having it auto translated would be the best, because the strings are very repetitive and prone to change. And I think it should be translated because it's part of a 'normal' page where eveything else can be translated and not a full auto generated reference page |
c7acded
to
2be9b42
Compare
da10890
to
7111c69
Compare
add to pages
7111c69
to
db7e45f
Compare
7cb14d8
to
3643c0a
Compare
@simonhyll for some reason it's failing on set_statuses, any ideas? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really neat solution, I just left a small suggestion.
Co-Authored-By: Paul Valladares <[email protected]>
I didn't know about this one and opened #2522 just pick the one you prefer and close the other (or we could merge this one and apply my other changes idk) |
I'm kinda leaning into yours now that I have to write some scope docs.. yours is more flexible :) |
Something I wish we could have is to keep the headers in the "On this page" section :/ doesn't seem like it's possible since we're inlining HTML instead of markdown |
fyi alternatively we could import the markdown files directly:
but that still doesn't preserve the headers :( |
np, I just looked at it and was thinking about using yours because you already provided more usage context. Notice that mine changes around 26 files and yours 17, so a few pages was changed without need, or are missing tables (I added to all pages with or without content) |
and I always enjoy seeing how people solves the same problem that I did in a totally different way |
i'll go ahead and merge this one, i wanna move a bit faster to write as much content as i can :D |
known regression from #1890 the headings still aren't part of the table of contents though :(
This is mostly to improve DX. Right now it just gets the generated md file and outputs it. Pending i18n functionality
Usage: