Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create plugin http guide #1725

Merged
merged 12 commits into from
Dec 19, 2023

Conversation

vasfvitor
Copy link
Contributor

@vasfvitor vasfvitor commented Dec 3, 2023

What kind of changes does this PR include?

  • New or updated content

Description

What about the line highlight? For this and other guides
Current:
/\\.plugin.*$/

Another ways:
{6}

ins=/\\.plugin.*$/

ins={6}

there may be more ways, not sure, reference: https://starlight.astro.build/guides/authoring-content/#expressive-code-features

Copy link

netlify bot commented Dec 3, 2023

Deploy Preview for tauri-docs-starlight ready!

Name Link
🔨 Latest commit a01ac18
🔍 Latest deploy log https://app.netlify.com/sites/tauri-docs-starlight/deploys/65817e2b490ae80008e31041
😎 Deploy Preview https://deploy-preview-1725--tauri-docs-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@lorenzolewis
Copy link
Member

I prefer using line numbers to highlight I think. That's what's most common and I've seen in other places so I think it will be easier for contributors to understand (especially since what's being highlighted is a full line and not just a word or two).

Copy link
Member

@lorenzolewis lorenzolewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few changes here then it's good to go!

src/content/docs/features/http-client.mdx Outdated Show resolved Hide resolved
src/content/docs/features/http-client.mdx Show resolved Hide resolved
src/content/docs/features/http-client.mdx Outdated Show resolved Hide resolved
@lorenzolewis
Copy link
Member

Thanks @vasfvitor ! Just added a link to the Fetch API and the rest is good to go!

@lorenzolewis lorenzolewis merged commit 348e0f1 into tauri-apps:next Dec 19, 2023
6 checks passed
@vasfvitor vasfvitor deleted the guide-plugin-http branch December 20, 2023 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants